Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation menus & commands are no longer enabled #783

Closed
tortmayr opened this issue Nov 14, 2022 · 0 comments · Fixed by eclipse-glsp/glsp-vscode-integration#28
Closed

Navigation menus & commands are no longer enabled #783

tortmayr opened this issue Nov 14, 2022 · 0 comments · Fixed by eclipse-glsp/glsp-vscode-integration#28
Assignees
@tortmayr
Labels
bug Something isn't working vscode

Comments

@tortmayr
Copy link
Contributor

In the VS Code integration Workflow example navigation no longer works. Neither via commands nor via menu. In fact, the menu entries are not visible at all.
It seems like the registration of the workflow.editorSelectedElementsAmount context key got lost during a refactoring
@tortmayr tortmayr added bug Something isn't working vscode labels Nov 14, 2022
@tortmayr tortmayr self-assigned this Nov 14, 2022
@tortmayr tortmayr mentioned this issue Nov 14, 2022
Merged
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Nov 14, 2022
@tortmayr
#783 Fix navigation & update to latest glsp client nighly
4c15f85 
Upgrade yarn lock to consume latest glsp client version. (to consume eclipse-glsp/glsp-client@4a5a0ee)

Refactor server download script (analog to eclipse-glsp/glsp-client#194)
Use yarn resolutions to resolve sprotty version conflict (caused by upstream sprotty-vscode-webview)

Re-add missing registration of the editorSelectedElementsAmount context key
Fixes eclipse-glsp/glsp/issues/783
Fixes eclipse-glsp/glsp/issues/782
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Nov 14, 2022
@tortmayr
#783 Fix navigation & update to latest glsp client nighly (#28)
151c3c1 
Upgrade yarn lock to consume latest glsp client version. (to consume eclipse-glsp/glsp-client@4a5a0ee)

Refactor server download script (analog to eclipse-glsp/glsp-client#194)
Use yarn resolutions to resolve sprotty version conflict (caused by upstream sprotty-vscode-webview)

Re-add missing registration of the editorSelectedElementsAmount context key
Fixes eclipse-glsp/glsp/issues/783
Fixes eclipse-glsp/glsp/issues/782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
bug Something isn't working vscode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#783 Fix navigation & update to latest glsp client nighly eclipse-glsp/glsp-vscode-integration
1 participant
@tortmayr