Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glsp-vscode-integration workflow example out of sync with glsp-server #782

Closed
kolovos opened this issue Nov 13, 2022 · 1 comment · Fixed by eclipse-glsp/glsp-vscode-integration#28
Closed

glsp-vscode-integration workflow example out of sync with glsp-server #782

kolovos opened this issue Nov 13, 2022 · 1 comment · Fixed by eclipse-glsp/glsp-vscode-integration#28
Assignees
@tortmayr
Labels
bug Something isn't working

Comments

@kolovos
Copy link

kolovos commented Nov 13, 2022

Running the Workflow GLSP Example Extension (External GLSP Server) configuration of the latest version of the workflow VS Code extension, against the latest version of the workflow GLSP server produces a protocol mismatch exception on the server side, which suggests that the client and the server implementations may have fallen out of sync.

Caused by: org.eclipse.lsp4j.jsonrpc.ResponseErrorException: Protocol version mismatch! The client protocol version '0.9.0' is not compatible with the server protocol version '1.0.0'!
	at org.eclipse.glsp.server.protocol.DefaultGLSPServer.validateProtocolVersion(DefaultGLSPServer.java:97)
	at org.eclipse.glsp.server.protocol.DefaultGLSPServer.initialize(DefaultGLSPServer.java:69)
	... 16 more
@kolovos kolovos added the bug Something isn't working label Nov 13, 2022
@planger planger mentioned this issue Nov 14, 2022
Closed
@tortmayr
Copy link
Contributor

Hi @kolovos,
thanks for raising this issue. The problem should be fixed once this PR is reviewed and merged: eclipse-glsp/glsp-vscode-integration#28

@planger planger assigned tortmayr and unassigned xai Nov 14, 2022
@planger planger mentioned this issue Nov 14, 2022
Merged
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Nov 14, 2022
@tortmayr
#783 Fix navigation & update to latest glsp client nighly
4c15f85 
Upgrade yarn lock to consume latest glsp client version. (to consume eclipse-glsp/glsp-client@4a5a0ee)

Refactor server download script (analog to eclipse-glsp/glsp-client#194)
Use yarn resolutions to resolve sprotty version conflict (caused by upstream sprotty-vscode-webview)

Re-add missing registration of the editorSelectedElementsAmount context key
Fixes eclipse-glsp/glsp/issues/783
Fixes eclipse-glsp/glsp/issues/782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#783 Fix navigation & update to latest glsp client nighly eclipse-glsp/glsp-vscode-integration
3 participants
@xai @tortmayr @kolovos