Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a better mechanism to define the dirty-state of the model #6

Closed
tortmayr opened this issue Nov 8, 2019 · 0 comments · Fixed by #32
Closed

Find a better mechanism to define the dirty-state of the model #6

tortmayr opened this issue Nov 8, 2019 · 0 comments · Fixed by #32
Assignees
@planger

Comments

@tortmayr
Copy link
Contributor

tortmayr commented Nov 8, 2019

In the fix for #36 we mark a model as dirty as soon as an executeOperation_* is sent to the server. However, this is not a very reliable mechanism. Without having thought this through entirely, imho, the server needs to decide whether a model is dirty or not; eventually, the server decides which action is actually performed or not, isn't it?

[migrated from https://github.com/eclipsesource/graphical-lsp/issues/62]
planger added a commit that referenced this issue Jan 5, 2020
@planger
Enable handlers returning multiple actions to a client action
d50f231 
This is in preparation for #6.
planger added a commit that referenced this issue Jan 5, 2020
@planger
Let server handle the dirty state
3d8d5cc 
Resolves #6
@planger planger mentioned this issue Jan 5, 2020
Merged
@planger planger self-assigned this Jan 5, 2020
tortmayr pushed a commit that referenced this issue Jan 10, 2020
@planger @tortmayr
Let server handle the dirty state (#32)
46d078f 
* Enable handlers returning multiple actions to a client action

This is in preparation for #6.

* Let server handle the dirty state

Resolves #6
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this issue Dec 21, 2024
@planger @tortmayr
Let server handle the dirty state (eclipse-glsp#32)
41e0bd7 
* Enable handlers returning multiple actions to a client action

This is in preparation for eclipse-glsp#6.

* Let server handle the dirty state

Resolves eclipse-glsp#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@planger planger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Let server handle the dirty state eclipse-glsp/glsp-server
2 participants
@planger @tortmayr