Skip to content
This repository has been archived by the owner on Jan 15, 2020. It is now read-only.

Find a better mechanism to define the dirty-state of the model #62

Open
planger opened this issue Sep 21, 2018 · 2 comments
Open

Find a better mechanism to define the dirty-state of the model #62

planger opened this issue Sep 21, 2018 · 2 comments
Assignees

Comments

@planger
Copy link
Collaborator

planger commented Sep 21, 2018

In the fix for #36 we mark a model as dirty as soon as an executeOperation_* is sent to the server. However, this is not a very reliable mechanism. Without having thought this through entirely, imho, the server needs to decide whether a model is dirty or not; eventually, the server decides which action is actually performed or not, isn't it?

@CamilleLetavernier
Copy link
Collaborator

Without having thought this through entirely, imho, the server needs to decide whether a model is dirty or not; eventually, the server decides which action is actually performed or not, isn't it?

I agree; especially when the "hints" aren't enough, the client doesn't have enough information to know if an edition operation will be accepted or rejected, or even if it's valid but doesn't actually modify the model (e.g. navigate a link...)

@planger
Copy link
Collaborator Author

planger commented May 17, 2019

This is related to #231. Once we have a command stack on the server, it'll be easy for the server to define the dirty-state of the diagram.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants