Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ROS 2 Mangling methods [19693] #83

Merged
merged 8 commits into from
Nov 3, 2023
Merged

Add ROS 2 Mangling methods [19693] #83

merged 8 commits into from
Nov 3, 2023

Conversation

irenebm
Copy link
Contributor

@irenebm irenebm commented Oct 26, 2023

No description provided.

@irenebm
Add ROS 2 Mangling methods
e72cfa7 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm irenebm temporarily deployed to codecov October 26, 2023 10:27 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023 •
edited
Loading

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Files Coverage Δ
cpp_utils/src/cpp/ros2_mangling.cpp 53.23% <53.23%> (ø)

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@irenebm irenebm temporarily deployed to codecov October 26, 2023 13:51 — with GitHub Actions Inactive
@irenebm
Update versions.md
402f3f6 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm irenebm temporarily deployed to codecov October 27, 2023 09:24 — with GitHub Actions Inactive
This was referenced Oct 27, 2023
Merged
Merged
@irenebm irenebm temporarily deployed to codecov October 27, 2023 09:48 — with GitHub Actions Inactive
@irenebm irenebm force-pushed the feature/ros2_mangling branch from ee6172e to d636d24 Compare October 27, 2023 10:41
@irenebm
Fix filename in CMakeLists.txt
6988b62 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm irenebm force-pushed the feature/ros2_mangling branch from d636d24 to 6988b62 Compare October 27, 2023 10:57
@irenebm irenebm temporarily deployed to codecov October 27, 2023 10:57 — with GitHub Actions Inactive
@irenebm
Fix filename in CMakeLists.txt
71a05ef 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm irenebm force-pushed the feature/ros2_mangling branch from 6988b62 to 71a05ef Compare October 30, 2023 07:28
@irenebm irenebm temporarily deployed to codecov October 30, 2023 07:28 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov October 30, 2023 07:51 — with GitHub Actions Inactive
@irenebm irenebm changed the title Add ROS 2 Mangling methods Add ROS 2 Mangling methods [19693] Oct 30, 2023
@irenebm irenebm mentioned this pull request Oct 30, 2023
Merged
2 tasks
jepemi
jepemi reviewed Oct 31, 2023
View reviewed changes
cpp_utils/include/cpp_utils/ros2_mangling.hpp Outdated Show resolved Hide resolved
cpp_utils/include/cpp_utils/ros2_mangling.hpp Outdated Show resolved Hide resolved
cpp_utils/src/cpp/ros2_mangling.cpp Outdated Show resolved Hide resolved
cpp_utils/src/cpp/ros2_mangling.cpp Outdated Show resolved Hide resolved
cpp_utils/test/unittest/ros2_mangling/ROS2ManglingTest.cpp Outdated Show resolved Hide resolved
jepemi
jepemi requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply changes

@irenebm
Apply changes
260d70c 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
jepemi
jepemi requested changes Nov 2, 2023
View reviewed changes
cpp_utils/src/cpp/ros2_mangling.cpp Outdated Show resolved Hide resolved
cpp_utils/include/cpp_utils/ros2_mangling.hpp Show resolved Hide resolved
cpp_utils/include/cpp_utils/ros2_mangling.hpp Outdated Show resolved Hide resolved
cpp_utils/include/cpp_utils/ros2_mangling.hpp Outdated Show resolved Hide resolved
cpp_utils/include/cpp_utils/ros2_mangling.hpp Outdated Show resolved Hide resolved
cpp_utils/include/cpp_utils/ros2_mangling.hpp Outdated Show resolved Hide resolved
cpp_utils/include/cpp_utils/ros2_mangling.hpp Outdated Show resolved Hide resolved
@irenebm
Apply changes
8fe9072 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm irenebm temporarily deployed to codecov November 2, 2023 15:44 — with GitHub Actions Inactive
jepemi
jepemi requested changes Nov 3, 2023
View reviewed changes
cpp_utils/include/cpp_utils/ros2_mangling.hpp Outdated Show resolved Hide resolved
cpp_utils/include/cpp_utils/ros2_mangling.hpp Outdated Show resolved Hide resolved
cpp_utils/include/cpp_utils/ros2_mangling.hpp Show resolved Hide resolved
cpp_utils/include/cpp_utils/ros2_mangling.hpp Show resolved Hide resolved
cpp_utils/include/cpp_utils/ros2_mangling.hpp Show resolved Hide resolved
cpp_utils/include/cpp_utils/ros2_mangling.hpp Outdated Show resolved Hide resolved
@irenebm
Apply changes
0af87a7 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
jepemi
jepemi approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15 rsanchez15 merged commit 4b65ba3 into main Nov 3, 2023
15 of 16 checks passed
@rsanchez15 rsanchez15 deleted the feature/ros2_mangling branch November 3, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepemi jepemi jepemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irenebm @codecov-commenter @jepemi @rsanchez15