Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate schemas in ROS 2 msg format [19693] #69

Merged
merged 10 commits into from
Nov 3, 2023
Merged

Generate schemas in ROS 2 msg format [19693] #69

merged 10 commits into from
Nov 3, 2023

Conversation

irenebm
Copy link
Contributor

@irenebm irenebm commented Oct 24, 2023 •
edited
Loading

@irenebm
Create demangle files
ee687ed 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Add demangle test
757c705 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Remap demangle -> ros2_mangling & add comments
670f484 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Add mangling functions
6bf3358 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Update versions.md
f679627 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Move ROS 2 Mangling methods to cpp_utils package
ff1c61a 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Store schemas in ROS 2 msg format
9f92fd4 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Update versions.md
4d5734f 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm irenebm mentioned this pull request Oct 27, 2023
Merged
@irenebm irenebm marked this pull request as ready for review October 27, 2023 09:39
@irenebm irenebm changed the title Demangler for ROS 2 topics Generate schemas in ROS 2 msg format Oct 27, 2023
@irenebm irenebm changed the title Generate schemas in ROS 2 msg format Generate schemas in ROS 2 msg format [19693] Oct 30, 2023
@irenebm irenebm mentioned this pull request Oct 30, 2023
Merged
2 tasks
jepemi
jepemi requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply suggestions

ddspipe_participants/test/CMakeLists.txt Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/types/dynamic_types/schema_msg.cpp Show resolved Hide resolved
ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved
@irenebm
Apply changes
e5e7511 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
jepemi
jepemi approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irenebm
Uncrustify
5e5e78e 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm irenebm merged commit 1c37ea5 into main Nov 3, 2023
23 checks passed
@irenebm irenebm deleted the feature/demangle branch November 3, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepemi jepemi jepemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irenebm @jepemi