Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message receiver improvements <master> [7485] #987

Merged
merged 5 commits into from
Jan 31, 2020
Merged

Message receiver improvements <master> [7485] #987

merged 5 commits into from
Jan 31, 2020

Conversation

MiguelCompany
Copy link
Member

Port of #986

adolfomarver
adolfomarver reviewed Jan 31, 2020
View reviewed changes
include/fastdds/rtps/common/Types.h
#define BIT6 0x40
#define BIT7 0x80

#define BIT(i) ((i==0) ? BIT0 : (i==1) ? BIT1 :(i==2)?BIT2:(i==3)?BIT3:(i==4)?BIT4:(i==5)?BIT5:(i==6)?BIT6:(i==7)?BIT7:0x0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!!!

adolfomarver
adolfomarver approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@adolfomarver adolfomarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany merged commit 15f813e into master Jan 31, 2020
@MiguelCompany MiguelCompany deleted the bugfix/message-receiver-security-memory/master branch January 31, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adolfomarver adolfomarver adolfomarver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @richiware @adolfomarver