Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message receiver improvements <1.9.x> [7482] #986

Merged
merged 7 commits into from
Feb 18, 2020
Merged

Message receiver improvements <1.9.x> [7482] #986

merged 7 commits into from
Feb 18, 2020

Conversation

MiguelCompany
Copy link
Member

This PR contains several improvements related to MessageReceiver:

  • Allows the reception of messages bigger than 64K if the transport layer supports them
  • The style has been applied, and some clean-up has been performed
  • When built with security, if the participant is not configured as secure, no data is allocated for the temporary decryption buffer. To accomplish this it was necessary to create the receiver resources after initializing the security manager, but the internal call to create_entities needed the receiver resources to be already created. In order to solve this circular dependency, the init method had to be split in two phases, and the unit tests of the SecurityManager had to be updated accordingly.

@MiguelCompany MiguelCompany force-pushed the bugfix/message-receiver-security-memory/1.9.x branch from 1453a5a to cc46e02 Compare January 30, 2020 14:48
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany force-pushed the bugfix/message-receiver-security-memory/1.9.x branch from cc46e02 to b9a78f4 Compare January 31, 2020 07:06
adolfomarver
adolfomarver previously approved these changes Jan 31, 2020
View reviewed changes
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany mentioned this pull request Jan 31, 2020
Merged
@MiguelCompany MiguelCompany force-pushed the bugfix/message-receiver-security-memory/1.9.x branch from b9a78f4 to 97f068f Compare February 6, 2020 11:37
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany changed the title Message receiver improvements <1.9.x> Message receiver improvements <1.9.x> [7482] Feb 6, 2020
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany
Copy link
Member Author

MiguelCompany commented Feb 7, 2020 •
edited
Loading

CI glitch on Mac, relaunching:

  • Mac Build Status

@MiguelCompany MiguelCompany force-pushed the bugfix/message-receiver-security-memory/1.9.x branch from 884fcb1 to 0b9bac5 Compare February 17, 2020 14:11
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

adolfomarver
adolfomarver approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@adolfomarver adolfomarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MiguelCompany MiguelCompany merged commit 54e4a62 into 1.9.x Feb 18, 2020
@MiguelCompany MiguelCompany deleted the bugfix/message-receiver-security-memory/1.9.x branch February 18, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adolfomarver adolfomarver adolfomarver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @richiware @adolfomarver