Fixed build without security after #938 #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
pushed a commit
that referenced
this pull request
Feb 28, 2020
This is a port of #938 and #979 and 3778a97 from 1.9.X * Refs #7116. Separating RTPSMessageGroup_t into a private header. * Refs #7116. Passing send buffers management responsibility to RTPSParticipantImpl. * Refs #7116. RAII on RTPSMessageGroup_t. * Refs #7116. Protecting access to buffer pool. * Refs #7116. Preallocating one buffer per expected thread. * Refs #7116. Protecting access to buffer pool with specific mutex. * Refs #7116. New SendBuffersManager class. * Refs #7116. Allowing wrapping buffer on RTPSMessageGroup_t. * Refs #7116. Using a single allocation for all initially allocated buffers. * Refs #7116. Adding assertion. * Refs #7116. Fixed alignment. * Refs #7116. Correct calculation of raw buffer size. * Refs #7116. Early return on security initialization failure. * Refs #7116. Making send buffers allocation configurable. * Refs #7116. Adding XML configuration for send_buffers allocation. * Refs #7116. Adding participant allocation attributes to XML parser unit test. * Refs #7165. Fixed warnings. * Refs #7165. Fixed leak. * Refs #7165. Return send buffer even if an exception is thrown. * Refs #7165. Correctly return send buffer. * Fixed build without security.
MiguelCompany
added a commit
that referenced
this pull request
Feb 28, 2020
* Refs #7166 RTPSMessageGroup_t preallocation This is a port of #938 and #979 and 3778a97 from 1.9.X * Refs #7116. Separating RTPSMessageGroup_t into a private header. * Refs #7116. Passing send buffers management responsibility to RTPSParticipantImpl. * Refs #7116. RAII on RTPSMessageGroup_t. * Refs #7116. Protecting access to buffer pool. * Refs #7116. Preallocating one buffer per expected thread. * Refs #7116. Protecting access to buffer pool with specific mutex. * Refs #7116. New SendBuffersManager class. * Refs #7116. Allowing wrapping buffer on RTPSMessageGroup_t. * Refs #7116. Using a single allocation for all initially allocated buffers. * Refs #7116. Adding assertion. * Refs #7116. Fixed alignment. * Refs #7116. Correct calculation of raw buffer size. * Refs #7116. Early return on security initialization failure. * Refs #7116. Making send buffers allocation configurable. * Refs #7116. Adding XML configuration for send_buffers allocation. * Refs #7116. Adding participant allocation attributes to XML parser unit test. * Refs #7165. Fixed warnings. * Refs #7165. Fixed leak. * Refs #7165. Return send buffer even if an exception is thrown. * Refs #7165. Correctly return send buffer. * Fixed build without security. * Refs #7166. Apply suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a build error introduced on #938 when building without security.
Skipping tests, as they are always run with security enabled.