Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTPSMessageGroup_t preallocation <master> [7166] #1032

Merged
merged 2 commits into from
Feb 28, 2020
Merged

RTPSMessageGroup_t preallocation <master> [7166] #1032

merged 2 commits into from
Feb 28, 2020

Conversation

IkerLuengo
Copy link
Contributor

@IkerLuengo IkerLuengo commented Feb 26, 2020 •
edited
Loading

This is a port of #938 and #979 and 3778a97 from 1.9.X

@IkerLuengo IkerLuengo force-pushed the feature/message-groups-allocation/master branch from 041a506 to ac61fbd Compare February 26, 2020 07:12
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@IkerLuengo IkerLuengo force-pushed the feature/message-groups-allocation/master branch from ac61fbd to 1ad82d4 Compare February 26, 2020 15:39
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@IkerLuengo IkerLuengo force-pushed the feature/message-groups-allocation/master branch from 1ad82d4 to f86b30a Compare February 27, 2020 10:25
@richiware
Copy link
Member

richiware commented Feb 27, 2020 •
edited by IkerLuengo
Loading

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status <- Failing on a test known to be unstable

@IkerLuengo IkerLuengo force-pushed the feature/message-groups-allocation/master branch from f86b30a to c6643ad Compare February 28, 2020 09:14
MiguelCompany
MiguelCompany requested changes Feb 28, 2020
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor, some important changes

include/fastdds/rtps/attributes/RTPSParticipantAllocationAttributes.hpp Outdated Show resolved Hide resolved
include/fastdds/rtps/common/CDRMessage_t.h Show resolved Hide resolved
src/cpp/rtps/messages/SendBuffersManager.cpp Outdated Show resolved Hide resolved
IkerLuengo and others added 2 commits February 28, 2020 13:01
@IkerLuengo @MiguelCompany
Refs #7166 RTPSMessageGroup_t preallocation
3125b88 
This is a port of #938 and #979 and 3778a97 from 1.9.X

* Refs #7116. Separating RTPSMessageGroup_t into a private header.

* Refs #7116. Passing send buffers management responsibility to RTPSParticipantImpl.

* Refs #7116. RAII on RTPSMessageGroup_t.

* Refs #7116. Protecting access to buffer pool.

* Refs #7116. Preallocating one buffer per expected thread.

* Refs #7116. Protecting access to buffer pool with specific mutex.

* Refs #7116. New SendBuffersManager class.

* Refs #7116. Allowing wrapping buffer on RTPSMessageGroup_t.

* Refs #7116. Using a single allocation for all initially allocated buffers.

* Refs #7116. Adding assertion.

* Refs #7116. Fixed alignment.

* Refs #7116. Correct calculation of raw buffer size.

* Refs #7116. Early return on security initialization failure.

* Refs #7116. Making send buffers allocation configurable.

* Refs #7116. Adding XML configuration for send_buffers allocation.

* Refs #7116. Adding participant allocation attributes to XML parser unit test.

* Refs #7165. Fixed warnings.

* Refs #7165. Fixed leak.

* Refs #7165. Return send buffer even if an exception is thrown.

* Refs #7165. Correctly return send buffer.

* Fixed build without security.
@MiguelCompany
Refs #7166. Apply suggestions from code review
2f9f49c
@MiguelCompany MiguelCompany force-pushed the feature/message-groups-allocation/master branch from c6643ad to 2f9f49c Compare February 28, 2020 12:02
@richiware
Copy link
Member

richiware commented Feb 28, 2020 •
edited by MiguelCompany
Loading

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status
    • Known flaky test failures

@MiguelCompany MiguelCompany merged commit 9b7f143 into master Feb 28, 2020
@MiguelCompany MiguelCompany deleted the feature/message-groups-allocation/master branch February 28, 2020 14:48
@MiguelCompany MiguelCompany mentioned this pull request Jul 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IkerLuengo @richiware @MiguelCompany