Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built-in endpoints history configuration [6997] #907

Merged
merged 5 commits into from
Feb 11, 2020
Merged

Built-in endpoints history configuration [6997] #907

merged 5 commits into from
Feb 11, 2020

Conversation

IkerLuengo
Copy link
Contributor

Allow configuration of built-in endpoint payload size

@IkerLuengo IkerLuengo changed the title Built-in endpoints history configuration Built-in endpoints history configuration [6997] Dec 2, 2019
MiguelCompany
MiguelCompany requested changes Dec 4, 2019
View reviewed changes
src/cpp/rtps/builtin/discovery/endpoint/EDPClient.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/endpoint/EDPClient.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/endpoint/EDPServer.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/endpoint/EDPServer.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/endpoint/EDPServer.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/endpoint/EDPSimple.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/endpoint/EDPSimple.cpp Outdated Show resolved Hide resolved
@IkerLuengo IkerLuengo force-pushed the feature/enpoints-history-configuration/1.9.x branch from ff3ff84 to e533f99 Compare December 11, 2019 09:03
@IkerLuengo
Copy link
Contributor Author

IkerLuengo commented Dec 12, 2019 •
edited
Loading

Relaunched tests:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status
  • Performance Build Status

@MiguelCompany MiguelCompany added this to the v1.9.4 milestone Dec 18, 2019
@MiguelCompany MiguelCompany modified the milestones: v1.9.4, v1.9.5 Jan 13, 2020
@IkerLuengo IkerLuengo force-pushed the feature/enpoints-history-configuration/1.9.x branch from e533f99 to 83ee78b Compare January 15, 2020 11:33
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@IkerLuengo
Copy link
Contributor Author

Windows error is unrelated.
Linux error seems unrelated and is not reproduced. Relaunched:

  • Build Status

@IkerLuengo IkerLuengo force-pushed the feature/enpoints-history-configuration/1.9.x branch 2 times, most recently from 6250760 to 2f485ea Compare January 27, 2020 15:09
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@IkerLuengo IkerLuengo force-pushed the feature/enpoints-history-configuration/1.9.x branch from 2f485ea to 1a76d1a Compare January 29, 2020 10:14
@MiguelCompany
Copy link
Member

@IkerLuengo I will not review this until #918 is merged, as this one will surely need to be rebased after that one.

@MiguelCompany MiguelCompany force-pushed the feature/enpoints-history-configuration/1.9.x branch from 1a76d1a to 1174ead Compare February 10, 2020 15:30
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

MiguelCompany
MiguelCompany approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 8e47167 into 1.9.x Feb 11, 2020
@MiguelCompany MiguelCompany deleted the feature/enpoints-history-configuration/1.9.x branch February 11, 2020 06:29
IkerLuengo added a commit that referenced this pull request Feb 21, 2020
@IkerLuengo
Refs 5751. Built-in endpoints history configuration
fc0f783 
This is a port of #907 from 1.9.x
@IkerLuengo IkerLuengo mentioned this pull request Feb 21, 2020
Merged
IkerLuengo added a commit that referenced this pull request Mar 3, 2020
@IkerLuengo
Refs 5751. Built-in endpoints history configuration
6f862d0 
This is a port of #907 from 1.9.x
MiguelCompany added a commit that referenced this pull request Mar 3, 2020
@IkerLuengo @MiguelCompany
Built-in endpoints history configuration (#1023)
53a326e 
* Refs 5751. Built-in endpoints history configuration

This is a port of #907 from 1.9.x

* Apply suggestions from code review

Co-Authored-By: Miguel Company <miguelcompany@eprosima.com>

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@IkerLuengo @richiware @MiguelCompany