Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built-in endpoints history configuration <master> [7705] #1023

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Built-in endpoints history configuration <master> [7705] #1023

merged 2 commits into from
Mar 3, 2020

Conversation

IkerLuengo
Copy link
Contributor

This is a port of #907 from 1.9.x

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@IkerLuengo IkerLuengo force-pushed the feature/endpoints-history-configuration/master branch from fc0f783 to bbe0fc1 Compare February 27, 2020 11:19
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@IkerLuengo IkerLuengo force-pushed the feature/endpoints-history-configuration/master branch from bbe0fc1 to 26973c8 Compare March 2, 2020 08:20
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

MiguelCompany
MiguelCompany requested changes Mar 3, 2020
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and then solve minor style issues

src/cpp/rtps/builtin/discovery/endpoint/EDPClient.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/endpoint/EDPClient.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/endpoint/EDPClient.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/endpoint/EDPClient.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/endpoint/EDPServer.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/participant/PDP.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/participant/PDPServer.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/participant/PDPServer.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/participant/PDPServer.cpp Outdated Show resolved Hide resolved
IkerLuengo and others added 2 commits March 3, 2020 15:30
@IkerLuengo
Refs 5751. Built-in endpoints history configuration
6f862d0 
This is a port of #907 from 1.9.x
@IkerLuengo @MiguelCompany
Apply suggestions from code review
aa83a5c 
Co-Authored-By: Miguel Company <miguelcompany@eprosima.com>
@IkerLuengo IkerLuengo force-pushed the feature/endpoints-history-configuration/master branch from 1bcecc8 to aa83a5c Compare March 3, 2020 14:31
@richiware
Copy link
Member

richiware commented Mar 3, 2020 •
edited by MiguelCompany
Loading

Build status:

  • Linux Build Status
  • Mac Build Status
    • Known flaky failure
  • Windows Build Status
    • Known flaky failure

@MiguelCompany MiguelCompany merged commit 53a326e into master Mar 3, 2020
@MiguelCompany MiguelCompany deleted the feature/endpoints-history-configuration/master branch March 3, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IkerLuengo @richiware @MiguelCompany