Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.7.x] Fixing version file generation for correct 'fastrtpsgen -version' output #828

Merged
merged 1 commit into from
Nov 4, 2019
Merged

[1.7.x] Fixing version file generation for correct 'fastrtpsgen -version' output #828

merged 1 commit into from
Nov 4, 2019

Conversation

TSC21
Copy link

@TSC21 TSC21 commented Oct 26, 2019

Fixes #820, by applying eProsima/Fast-DDS-Gen#11.

Ouput:

$ fastrtpsgen -version
openjdk version "11.0.4" 2019-07-16
OpenJDK Runtime Environment (build 11.0.4+11-post-Ubuntu-1ubuntu218.04.3)
OpenJDK 64-Bit Server VM (build 11.0.4+11-post-Ubuntu-1ubuntu218.04.3, mixed mode, sharing)
fastrtpsgen version 1.7.2

@TSC21 TSC21 changed the base branch from master to 1.7.x October 26, 2019 10:55
@TSC21 TSC21 changed the title Fixing version file generation. [1.7.x] Fixing version file generation for correct 'fastrtpsgen -version' output Oct 26, 2019
@TSC21
Copy link
Author

TSC21 commented Oct 26, 2019

@richiprosima @LuisGP @laura-eprosima please review. This should also be backported to 1.7.2. Thanks!

@TSC21 TSC21 changed the base branch from 1.7.x to master October 26, 2019 11:14
@TSC21 TSC21 changed the base branch from master to 1.7.x October 26, 2019 11:14
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status
  • Performance Build Status

@TSC21
Copy link
Author

TSC21 commented Oct 27, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status
  • Performance Build Status

Seems to me that the CI build error is something unrelated. I can build this correctly on my end.

@TSC21
Copy link
Author

TSC21 commented Oct 30, 2019

@richiprosima friendly ping :)

@TSC21
Copy link
Author

TSC21 commented Nov 2, 2019

@richiware @LuisGP @laura-eprosima can this be merged? Thank you!

MiguelCompany
MiguelCompany approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MiguelCompany MiguelCompany merged commit 0bb98d0 into eProsima:1.7.x Nov 4, 2019
@TSC21 TSC21 deleted the fix/1.7.x_fastrtpsgen_version_file_gen branch November 7, 2019 11:40
@TSC21
Copy link
Author

TSC21 commented Nov 7, 2019

@MiguelCompany thank you very much for merging!

TSC21 added a commit to PX4/PX4-containers that referenced this pull request Nov 7, 2019
@TSC21
ROS2 Crystal container: Fast-RTPS 1.7: move back to upstream '1.7.x' …
54a70a5 
…branch as eProsima/Fast-DDS#828 was merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TSC21 @richiware @MiguelCompany