Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log any errors before cancel_init() #5530

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Log any errors before cancel_init() #5530

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b4409d
Log any errors before cancel_init()
Santti4go Dec 30, 2024
c6c380c
Code style
Santti4go Dec 30, 2024
5cc9d57
Apply suggestion
Santti4go Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/cpp/rtps/security/SecurityManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ bool SecurityManager::init(
ParticipantSecurityAttributes& attributes,
const PropertyPolicy& participant_properties)
{
SecurityException exception;
try
{
SecurityException exception;
domain_id_ = participant_->get_domain_id();
auto part_attributes = participant_->get_attributes();
const PropertyPolicy log_properties = PropertyPolicyHelper::get_properties_with_prefix(
Expand Down Expand Up @@ -396,6 +396,13 @@ bool SecurityManager::init(
{
if (!e)
{
// Unexpected code path. Let's log any errors
logError(SECURITY, "Error while configuring security plugin.")
if (0 != strlen(exception.what()))
{
logError(SECURITY, exception.what())
}

cancel_init();
return false;
}
Expand Down
Loading