-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log any errors before cancel_init() #5530
Log any errors before cancel_init() #5530
Conversation
Hi @Santti4go, thank you for creating this PR. As this change is compatible with the latest version and this branch is out of its End of Standard Support Date, we would appreciate it if you could rebase your commits onto the branch master and then we would backport it to the supported branches. |
Signed-off-by: Santti4go <santiaupi@gmail.com>
Signed-off-by: Santti4go <santiaupi@gmail.com>
87837dc
to
c6c380c
Compare
Signed-off-by: Santti4go <santiaupi@gmail.com>
@EugenioCollado thanks for reviewing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x |
✅ Backports have been created
|
* Log any errors before cancel_init() Signed-off-by: Santti4go <santiaupi@gmail.com> * Code style Signed-off-by: Santti4go <santiaupi@gmail.com> * Apply suggestion Signed-off-by: Santti4go <santiaupi@gmail.com> --------- Signed-off-by: Santti4go <santiaupi@gmail.com> (cherry picked from commit 165d64e)
* Log any errors before cancel_init() Signed-off-by: Santti4go <santiaupi@gmail.com> * Code style Signed-off-by: Santti4go <santiaupi@gmail.com> * Apply suggestion Signed-off-by: Santti4go <santiaupi@gmail.com> --------- Signed-off-by: Santti4go <santiaupi@gmail.com> (cherry picked from commit 165d64e)
* Log any errors before cancel_init() Signed-off-by: Santti4go <santiaupi@gmail.com> * Code style Signed-off-by: Santti4go <santiaupi@gmail.com> * Apply suggestion Signed-off-by: Santti4go <santiaupi@gmail.com> --------- Signed-off-by: Santti4go <santiaupi@gmail.com> (cherry picked from commit 165d64e)
* Log any errors before cancel_init() Signed-off-by: Santti4go <santiaupi@gmail.com> * Code style Signed-off-by: Santti4go <santiaupi@gmail.com> * Apply suggestion Signed-off-by: Santti4go <santiaupi@gmail.com> --------- Signed-off-by: Santti4go <santiaupi@gmail.com> (cherry picked from commit 165d64e)
I think that the log macro should have been changed to |
I will take care of the changes you mention in a new PR and will also include them in the already created backports |
* Log any errors before cancel_init() (#5530) * Log any errors before cancel_init() Signed-off-by: Santti4go <santiaupi@gmail.com> * Code style Signed-off-by: Santti4go <santiaupi@gmail.com> * Apply suggestion Signed-off-by: Santti4go <santiaupi@gmail.com> --------- Signed-off-by: Santti4go <santiaupi@gmail.com> (cherry picked from commit 165d64e) * Add test for security initialization error (#5550) * Regression tests Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Update log macro Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Uncrustify Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Fix CI log flush Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> --------- Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> --------- Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> Co-authored-by: Santiago <95138114+Santti4go@users.noreply.github.com> Co-authored-by: EugenioCollado <121509066+EugenioCollado@users.noreply.github.com>
This PR improves the debugging process by adding a proper logging right before running
SecurityManager::cancel_init()
in this catch blockDescription
More details in this ticket #5531
@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x
Fixes #(issue)
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist