Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22321] Benchmark example updated (backport #5460) #5501

Open
wants to merge 1 commit into
base: 3.0.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 17, 2024

Description

I remake the benchmark example to new example style maintaining the original functionality.

@Mergifyio backport 3.1.x 3.0.x

Fixes #5398

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5460 done by [Mergify](https://mergify.com).

@mergify mergify bot mentioned this pull request Dec 17, 2024
13 tasks
@Mario-DL Mario-DL added this to the v3.0.2 milestone Dec 17, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 17, 2024
* Refs #22321: Benchmark example updated

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

* Refs #22321: Test CI for benchmark example and issue fixing

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

* Refs #22321: Fix type variable error

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

* Refs #22321: Corrections after review

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

* Refs #22321: Uncrustify fix

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

* Refs #22321: Uncrustified 2

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

* Refs #22321: Delate unused variable <sent> from PublisherApp.hpp

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

* Refs #22321: Extra corrections and fixes

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

* Refs #22321: Compose simplify for test

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

---------

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
(cherry picked from commit e99d6f3)
@Mario-DL Mario-DL force-pushed the mergify/bp/3.0.x/pr-5460 branch from 27731c8 to a22dd97 Compare January 22, 2025 10:36
@Mario-DL Mario-DL requested review from Mario-DL and removed request for richiprosima January 22, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants