[22321] Benchmark example updated #5460

Javgilavi · 2024-12-04T16:13:58Z

Description

I remake the benchmark example to new example style maintaining the original functionality.

@Mergifyio backport 3.1.x 3.0.x

Fixes #5398

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

rsanchez15

Pending example tests

Mario-DL

Good first iteration overall. The PR brings an interesting example.
In addition to my comments below, we would need to add this PR content Refactor benchmark example to the versions.md and replace the N/A with a tick in the checklist.

examples/cpp/benchmark/CLIParser.hpp

examples/cpp/benchmark/SubscriberApp.cpp

examples/cpp/benchmark/README.md

test/examples/test_benchmark.py

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Mario-DL

Leaving just some comments on previous suggestions

Mario-DL · 2024-12-16T09:55:19Z

Please, don't forget updating the versions.md and marking it in the contributor checklist

examples/cpp/benchmark/SubscriberApp.cpp

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Mario-DL

Just couple of comments

test/examples/benchmark.compose.yml

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Mario-DL

LGTM with green CI

Javgilavi · 2024-12-17T10:02:18Z

@Mergifyio backport 3.1.x 3.0.x

mergify · 2024-12-17T10:02:32Z

backport 3.1.x 3.0.x

✅ Backports have been created

#5500 [22321] Benchmark example updated (backport #5460) has been created for branch 3.1.x but encountered conflicts
#5501 [22321] Benchmark example updated (backport #5460) has been created for branch 3.0.x

* Refs #22321: Benchmark example updated Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Test CI for benchmark example and issue fixing Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Fix type variable error Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Corrections after review Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Uncrustify fix Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Uncrustified 2 Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Delate unused variable <sent> from PublisherApp.hpp Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Extra corrections and fixes Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Compose simplify for test Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> --------- Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> (cherry picked from commit e99d6f3) # Conflicts: # versions.md

* Refs #22321: Benchmark example updated Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Test CI for benchmark example and issue fixing Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Fix type variable error Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Corrections after review Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Uncrustify fix Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Uncrustified 2 Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Delate unused variable <sent> from PublisherApp.hpp Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Extra corrections and fixes Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Compose simplify for test Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> --------- Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> (cherry picked from commit e99d6f3)

* Benchmark example updated (#5460) * Refs #22321: Benchmark example updated Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Test CI for benchmark example and issue fixing Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Fix type variable error Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Corrections after review Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Uncrustify fix Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Uncrustified 2 Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Delate unused variable <sent> from PublisherApp.hpp Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Extra corrections and fixes Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> * Refs #22321: Compose simplify for test Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> --------- Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> (cherry picked from commit e99d6f3) # Conflicts: # versions.md * Fix conflict of versions.md Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> --------- Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com> Co-authored-by: Javier Gil Avilés <118965699+Javgilavi@users.noreply.github.com> Co-authored-by: Javier Gil Aviles <javiergil@eprosima.com>

Javgilavi added this to the v3.2.0 milestone Dec 4, 2024

Javgilavi requested a review from Mario-DL December 9, 2024 06:21

github-actions bot added the ci-pending PR which CI is running label Dec 9, 2024

rsanchez15 requested changes Dec 9, 2024

View reviewed changes

Javgilavi force-pushed the feature/benchmark-example branch from 4c8a8db to 54b8494 Compare December 11, 2024 08:48

rsanchez15 requested review from Mario-DL and removed request for Mario-DL December 11, 2024 09:58

Javgilavi requested review from Mario-DL and removed request for Mario-DL December 11, 2024 12:40

Mario-DL requested changes Dec 12, 2024

View reviewed changes

Javgilavi force-pushed the feature/benchmark-example branch from b1e7b77 to 791e055 Compare December 16, 2024 06:28

Javgilavi requested review from Mario-DL and rsanchez15 and removed request for Mario-DL December 16, 2024 06:28

Javgilavi added 7 commits December 16, 2024 09:48

Refs #22321: Benchmark example updated

00eac34

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Refs #22321: Test CI for benchmark example and issue fixing

734d0b7

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Refs #22321: Fix type variable error

ad70617

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Refs #22321: Corrections after review

f5f419b

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Refs #22321: Uncrustify fix

444329e

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Refs #22321: Uncrustified 2

8fa9eec

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Refs #22321: Delate unused variable <sent> from PublisherApp.hpp

f51d7b1

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Javgilavi force-pushed the feature/benchmark-example branch from cc2b477 to f51d7b1 Compare December 16, 2024 08:56

Javgilavi requested review from Mario-DL and removed request for Mario-DL December 16, 2024 08:57

Mario-DL requested changes Dec 16, 2024

View reviewed changes

Mario-DL reviewed Dec 16, 2024

View reviewed changes

examples/cpp/benchmark/SubscriberApp.cpp Outdated Show resolved Hide resolved

Refs #22321: Extra corrections and fixes

6fc1e8f

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Javgilavi requested a review from Mario-DL December 16, 2024 11:04

Mario-DL requested changes Dec 16, 2024

View reviewed changes

test/examples/benchmark.compose.yml Outdated Show resolved Hide resolved

test/examples/benchmark.compose.yml Outdated Show resolved Hide resolved

Javgilavi requested a review from Mario-DL December 16, 2024 14:57

Refs #22321: Compose simplify for test

2a4715b

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Javgilavi force-pushed the feature/benchmark-example branch from 8fcd7b4 to 2a4715b Compare December 16, 2024 15:15

Javgilavi requested review from Mario-DL and removed request for Mario-DL December 16, 2024 15:16

Mario-DL approved these changes Dec 16, 2024

View reviewed changes

rsanchez15 approved these changes Dec 16, 2024

View reviewed changes

Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Dec 17, 2024

Javgilavi merged commit e99d6f3 into master Dec 17, 2024
17 checks passed

Javgilavi deleted the feature/benchmark-example branch December 17, 2024 07:45

mergify bot mentioned this pull request Dec 17, 2024

[22321] Benchmark example updated (backport #5460) #5500

Merged

13 tasks

mergify bot mentioned this pull request Dec 17, 2024

[22321] Benchmark example updated (backport #5460) #5501

Open

13 tasks

Javgilavi restored the feature/benchmark-example branch December 17, 2024 10:17

Javgilavi deleted the feature/benchmark-example branch December 17, 2024 11:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[22321] Benchmark example updated #5460

[22321] Benchmark example updated #5460

Javgilavi commented Dec 4, 2024 •

edited by Mario-DL

Loading

rsanchez15 left a comment

Mario-DL left a comment

Mario-DL left a comment

Mario-DL commented Dec 16, 2024 •

edited

Loading

Mario-DL left a comment

Mario-DL left a comment

Javgilavi commented Dec 17, 2024

mergify bot commented Dec 17, 2024 •

edited

Loading

[22321] Benchmark example updated #5460

[22321] Benchmark example updated #5460

Conversation

Javgilavi commented Dec 4, 2024 • edited by Mario-DL Loading

Description

Contributor Checklist

Reviewer Checklist

rsanchez15 left a comment

Choose a reason for hiding this comment

Mario-DL left a comment

Choose a reason for hiding this comment

Mario-DL left a comment

Choose a reason for hiding this comment

Mario-DL commented Dec 16, 2024 • edited Loading

Mario-DL left a comment

Choose a reason for hiding this comment

Mario-DL left a comment

Choose a reason for hiding this comment

Javgilavi commented Dec 17, 2024

mergify bot commented Dec 17, 2024 • edited Loading

✅ Backports have been created

Javgilavi commented Dec 4, 2024 •

edited by Mario-DL

Loading

Mario-DL commented Dec 16, 2024 •

edited

Loading

mergify bot commented Dec 17, 2024 •

edited

Loading