-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21357] Remove TopicAttributes
from public APIs and make it private in xmlparser
#5085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mario-DL
added
doc-pending
Issue or PR which is pending to be documented
and removed
doc-pending
Issue or PR which is pending to be documented
labels
Jul 18, 2024
7 tasks
Mario-DL
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 23, 2024 08:09
Mario-DL
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 23, 2024 14:31
MiguelCompany
force-pushed
the
feature/21357
branch
4 times, most recently
from
July 26, 2024 07:54
b73d265
to
51077f2
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 26, 2024 08:10
MiguelCompany
previously approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 29, 2024 07:36
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 29, 2024 13:03
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
added
skip-ci
Automatically pass CI
and removed
versions-pending
ci-pending
PR which CI is running
labels
Jul 30, 2024
@MiguelCompany commits LGTM |
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 30, 2024 05:48
Mario-DL
commented
Jul 30, 2024
Mario-DL
commented
Jul 30, 2024
MiguelCompany
force-pushed
the
feature/21357
branch
from
July 30, 2024 06:25
c3c1c8f
to
0e284c1
Compare
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
force-pushed
the
feature/21357
branch
from
July 30, 2024 06:28
0e284c1
to
3a8a5a8
Compare
LGTM, ci full passed in 4c3d06e |
MiguelCompany
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Full green CI on commit 4c3d06e.
- Later changes are not modifying the code.
Ready to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
TopicAttributes
from public APIs in DDS and RTPS making usage of the newPublicationBuiltinTopicData
andSubscriptionBuiltinTopicData
.TopicAttributes
to the private folder and namespaceeprosima::fastdds::xmlparser
.get_*_buitin_topic_data()
methods inDataReader
andDataWriter
Contributor Checklist
versions.md
file (if applicable).TopicAttributes
from public APIs and make it private inxmlparser
Discovery-Server#100NOT NEEDED
NOT NEEDED
NOT NEEDED
Reviewer Checklist