Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19727] Refactor TSAN workflow #3934

Merged
merged 10 commits into from
Oct 23, 2023
Merged

[19727] Refactor TSAN workflow #3934

merged 10 commits into from
Oct 23, 2023

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Oct 17, 2023

Description

This PR refactors the Thread Sanitizer workflow.
It is now almost a copy of the Address Sanitizer one, and as such it uses the standard colcon build - colcon test workflow, using a custom colcon.meta.

The original report parsing and analysis has been kept, updating it to take the input from log/latest_test/fastrtps/stdout_stderr.log.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
    • Shall we have style rules for github actions?
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.
    • I haven't mentioned any backport, since the job is only run against master. Shall we change that?

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany force-pushed the testing/tsan2 branch 3 times, most recently from 713c25f to 277a198 Compare October 20, 2023 10:25
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.12.1 milestone Oct 23, 2023
@MiguelCompany MiguelCompany marked this pull request as ready for review October 23, 2023 05:55
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

.github/workflows/thread-sanitizer.yaml Outdated Show resolved Hide resolved
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
@EduPonz EduPonz merged commit c298043 into master Oct 23, 2023
6 of 8 checks passed
@EduPonz EduPonz deleted the testing/tsan2 branch October 23, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants