Ensure correct boost singleton destruction order [13288] #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
6b2181f to
ccdf876
Compare
|
@Mergifyio backport 2.4.x 2.3.x |
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Refs 13287. Ensure correct boost singleton destruction order. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13288. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13288. Fixed typo. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13288. Fixed link error on ListenerTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 80a44fe)
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Refs 13287. Ensure correct boost singleton destruction order. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13288. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13288. Fixed typo. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13288. Fixed link error on ListenerTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 80a44fe) # Conflicts: # test/unittest/dds/status/CMakeLists.txt
✅ Backports have been created
|
MiguelCompany
added a commit
that referenced
this pull request
Jan 21, 2022
* Ensure correct boost singleton destruction order (#2356) * Refs 13287. Ensure correct boost singleton destruction order. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13288. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13288. Fixed typo. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13288. Fixed link error on ListenerTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 80a44fe) # Conflicts: # test/unittest/dds/status/CMakeLists.txt * Refs 13287. Fix conflicts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first time an interprocess synchronization object is created by boost, a singleton is instantiated and its destructor is registered with std::atexit(&atexit_work).
This PR ensures that singleton is created before the DomainParticipantFactory instance so that it is destroyed after all the participants have been deleted.