Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add writer wait for acknowledgements for a specific instance [13252] #2233

Merged
merged 20 commits into from
Dec 20, 2021
Merged

Add writer wait for acknowledgements for a specific instance [13252] #2233

merged 20 commits into from
Dec 20, 2021

Conversation

JLBuenoLopez
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez commented Sep 27, 2021 •
edited by MiguelCompany
Loading

Add API to DataWriter: overload wait_for_acknowledgments for a specific instance.

Depends on #2356

MiguelCompany
MiguelCompany requested changes Sep 28, 2021
View reviewed changes
include/fastdds/dds/publisher/DataWriter.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/publisher/DataWriter.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.cpp Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastrtps_deprecated/publisher/PublisherHistory.cpp Outdated Show resolved Hide resolved
src/cpp/fastrtps_deprecated/publisher/PublisherHistory.cpp Outdated Show resolved Hide resolved
@JLBuenoLopez
Copy link
Contributor Author

@richiprosima please test windows

@JLBuenoLopez JLBuenoLopez added this to the v2.5.0 milestone Oct 26, 2021
@JLBuenoLopez JLBuenoLopez force-pushed the feature/writer-wait-for-acknowledgements-instance branch from 8a79678 to 14a191c Compare October 26, 2021 05:44
@JLBuenoLopez JLBuenoLopez force-pushed the feature/writer-wait-for-acknowledgements-instance branch from 14a191c to 9ac515e Compare December 10, 2021 07:00
MiguelCompany
MiguelCompany requested changes Dec 10, 2021
View reviewed changes
include/fastdds/dds/publisher/DataWriter.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastrtps_deprecated/publisher/PublisherHistory.cpp Outdated Show resolved Hide resolved
src/cpp/fastrtps_deprecated/publisher/PublisherHistory.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated Show resolved Hide resolved
MiguelCompany
MiguelCompany previously approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLBuenoLopez
Copy link
Contributor Author

Several DataWriter unittests have failed in both Windows CI. I will look into them!

MiguelCompany
MiguelCompany previously approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz changed the title [12412] Add writer wait for acknowledgements for a specific instance Add writer wait for acknowledgements for a specific instance [13252] Dec 14, 2021
@MiguelCompany
Copy link
Member

@richiprosima Please test mac

@MiguelCompany MiguelCompany force-pushed the feature/writer-wait-for-acknowledgements-instance branch from fcd4be0 to 156fb2c Compare December 16, 2021 14:39
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany force-pushed the feature/writer-wait-for-acknowledgements-instance branch 4 times, most recently from 5706a2a to 8031dd9 Compare December 17, 2021 06:13
EduPonz
EduPonz previously approved these changes Dec 17, 2021
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLBuenoLopez
Refs #12412: empty DataWriter API
d31afee 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12412: DataWriterImpl;;wait_for_acknowledgements initial implem…
4cca110 
…entation: preconditions

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12412: PublisherHistory::wait_for_acknowledgement_last_change i…
bf7a477 
…mplementation

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12412: add unit test
f949045 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12412: add blackbox test
b1ce23a 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12412: linters
10b997b 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12412: add checkout timeout to blackbox test
10c15d6 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12601: add logic to mock so all DataWriterTests pass
13b0f19 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12601: add output to blackbox test
b128b6d 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
JLBuenoLopez and others added 11 commits December 17, 2021 10:14
@JLBuenoLopez
Refs #12601: fix Windows warnings
6c8b926 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12601: linters
9ec448c 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12601: fix Windows warning
c9caea4 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12601: apply review suggestions
c1cf1b4 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12601: linters
cad3f46 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12601: performance, only calculate key if handle is NIL. Standa…
00706d3 
…rd compliance

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12412: add feature to versions.md
08794ec 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs 12412: apply review suggestions
7fe7f83 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12412: avoid including OpenSSL if not found
46aa63b 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@MiguelCompany @JLBuenoLopez
Refs 13252. Fix build with FASTDDS_STATISTICS=ON.
dd5f4c9 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany @JLBuenoLopez
Refs 13252. Avoid boost symbols export.
14ff18c 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@JLBuenoLopez JLBuenoLopez force-pushed the feature/writer-wait-for-acknowledgements-instance branch from 8031dd9 to 14ff18c Compare December 17, 2021 09:15
jsan-rt
jsan-rt approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 953afb9 into master Dec 20, 2021
@MiguelCompany MiguelCompany deleted the feature/writer-wait-for-acknowledgements-instance branch December 20, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsan-rt jsan-rt jsan-rt approved these changes

@MiguelCompany MiguelCompany MiguelCompany left review comments

@EduPonz EduPonz EduPonz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JLBuenoLopez @MiguelCompany @EduPonz @jsan-rt