Removing unused macro to avoid naming clashes #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
requested changes
Nov 3, 2021
There was a problem hiding this comment.
The code change is fine, but please fix DCO following the instructions here
As discussed in issue #1997 this macro was clashing with function from the Gtk3 UI library. As it is not needed it was proposed by MiguelCompany to remove it. Signed-off-by: Simon Schaefer <simon.schaefer@rwth-aachen.de>
|
I think something in the Mac script is broken. Somehow it doesn't reach one of your internal repos. Traceback (most recent call last):
File "buildcop.py", line 422, in <module>
main()
File "buildcop.py", line 270, in main
repo = git.Repo.clone_from(
File "/usr/local/lib/python3.8/site-packages/git/repo/base.py", line 1032, in clone_from
return cls._clone(git, url, to_path, GitCmdObjectDB, progress, multi_options, **kwargs)
File "/usr/local/lib/python3.8/site-packages/git/repo/base.py", line 973, in _clone
finalize_process(proc, stderr=stderr)
File "/usr/local/lib/python3.8/site-packages/git/util.py", line 329, in finalize_process
proc.wait(**kwargs)
File "/usr/local/lib/python3.8/site-packages/git/cmd.py", line 408, in wait
raise GitCommandError(self.args, status, errstr)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
cmdline: git clone --config=http.sslVerify=false -v https://gitlab.intranet.eprosima.com/eProsima/fastrtps-ci.git ci-repo
stderr: 'Cloning into 'ci-repo'...
fatal: unable to access 'https://gitlab.intranet.eprosima.com/eProsima/fastrtps-ci.git/': Couldn't connect to server
' |
|
@richiprosima Please test mac |
It happens from time to time. I relaunched the CI |
MiguelCompany
approved these changes
Nov 4, 2021
|
Everything went ok. Thank you @Foxei for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #1997 this macro was clashing with function from the Gtk3 UI library. As it is not needed it was proposed by MiguelCompany to remove it.