Naming clash generated by a macro define in the XML parser

[Foxei]

General Problem

The macro draw defined in the XMLParserCommon.h should be renamed to not replace code of other libraries. #defines do not take into account the namespace in which they were defined. Thus the macro is defined globally. Since it is a very generic name this can lead to problems if your own code or other libraries use the word draw in their code.

Link to the file in question: https://github.com/eProsima/Fast-DDS/blob/master/include/fastrtps/xmlparser/XMLParserCommon.h
Link to a stack overflow discussion about the issue with macros and namespaces: https://stackoverflow.com/questions/1088290/define-statements-within-a-namespace

Known libraries that have a naming clash

• Gtk 3.0

Suggested solution

Rename the macro so that it follows the structure of the namespaces.

Old Code

namespace eprosima {
namespace fastrtps {
namespace xmlparser {

#define draw(ident, text, ...) for (uint8_t i = ident + 1; i > 0; --i)(i == 1) ? printf(text, ## __VA_ARGS__) : printf( \        "\t")

[...]

New Code

namespace eprosima {
namespace fastrtps {
namespace xmlparser {

#define eprosima_fastrtps_xmlparser_draw(ident, text, ...) for (uint8_t i = ident + 1; i > 0; --i)(i == 1) ? printf(text, ## __VA_ARGS__) : printf( \        "\t")

[...]

[MiguelCompany]

The basic problem here is that macro shouldn't be on a public header.

In fact, I have checked and that macro is not being used, so we could remove it completely.