Remove #include <condition_variable> from Log.hpp [12720]
#2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo González <ricardo@richiware.dev>
#include <condition_variable> from Log.hpp#include <condition_variable> from Log.hpp [12720]
JLBuenoLopez
suggested changes
Oct 20, 2021
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
|
@richiprosima Please test this |
|
Done |
|
@richiprosima Please test aarch64 |
|
@richiprosima please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log.hppheader file is used everywhere. It's include<condition_variable>and<mutex>. This is incompatible with making a C# wrapper. This PR moves these included headers toLog.cpp.