Environment file feature #2211
Merged
Environment file feature #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richiprosima Please test mac |
|
@richiprosima Please test aarch64 |
* Refs #12199: file_exists implementation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: file_exists unit test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: Minor improvement on test Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Co-authored-by: Iker Luengo <ikerluengo@eprosima.com>
* Refs #12199: load_environment_file implementation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: load_environment_file tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: Check file is unserializeable and test Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: complete doxygen documentation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: Iker Luengo <ikerluengo@eprosima.com>
…t file (#2159) * Refs #12199: refactor load_environment_server_info taking into account environment file Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: add test cases to load_environment_server_info Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: fix Windows build Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: use specific configuration file in blackbox tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
* Refs #12199: add FileWatch header-only library and first PoC Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Implement watchers on SystemInfo and updated PoC Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: Test on watchers on SystemInfo Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: Linters Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: Removing code for PoC Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: Avoid warning on FileWatch Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: Only windows and linux supported If the platform is neither of these, the new methods do nothing. Otherwise, it fails when compiling on mac. Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: remove macro redefinition warning in Windows Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: notify when the file is closed and has been modified so the file modified callback is run once Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: modify FileWatch test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: avoid waiting and instead block until callback is executed Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: fix Windows and MacOS executions. Fix Windows comparison warning Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: ensure that file modification callback is only run once Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: fix datarace in FileWatchTest Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
* Refs #12199: refactor SystemInfo::get_env to use string instead of char* Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: set and get environment_file implementation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: get & set environment file test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: refactor get_env to read also from file. Update corresponding test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: remove unused parameter from callback. Fix test after rebase Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: add feature test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: feature implementation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: fix bug with FASTDDS_STATISTICS enabled Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: avoid including private header in public header file. Fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: apply suggestion of moving to RTPSDomainImpl all code related with file watcher Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: fix ServerClientEnvironmentSetUp test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: fix AddDiscoveryServerToListFromEnvironmentFile in Windows Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: disable AddDiscoveryServerToListFromEnvironmentFile in Apple Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: remove conflicting cases from ServerClientEnvironmentSetUp test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: remove unused member (fix Clang warning) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: apply review suggestion: move client_override flag to RTPSParticipantImpl Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: add review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: not run AddDiscoveryServerToListFromEnvironmentFile in Windows Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
605f7fd to
91c3c86
Compare
91c3c86 to
140f4f4
Compare
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
140f4f4 to
4598cc0
Compare
EduPonz
suggested changes
Sep 18, 2021
|
Uncrustify failed on a third-party file. That's not an error, is it? |
|
All failures are unrelated to this PR, so I'll go ahead and merge it |
SamuelWHalodi
pushed a commit
to SamuelWHalodi/Fast-DDS
that referenced
this pull request
Oct 4, 2021
* Add SystemInfo::file_exists (eProsima#2155) * Refs #12199: file_exists implementation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: file_exists unit test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: Minor improvement on test Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Co-authored-by: Iker Luengo <ikerluengo@eprosima.com> * Load environment file (eProsima#2157) * Refs #12199: load_environment_file implementation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: load_environment_file tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: Check file is unserializeable and test Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: complete doxygen documentation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: Iker Luengo <ikerluengo@eprosima.com> * Refactor load environment server info to take into account environment file (eProsima#2159) * Refs #12199: refactor load_environment_server_info taking into account environment file Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: add test cases to load_environment_server_info Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: fix Windows build Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: use specific configuration file in blackbox tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * filewatch integration (eProsima#2161) * Refs #12199: add FileWatch header-only library and first PoC Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Implement watchers on SystemInfo and updated PoC Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: Test on watchers on SystemInfo Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: Linters Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: Removing code for PoC Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: Avoid warning on FileWatch Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: Only windows and linux supported If the platform is neither of these, the new methods do nothing. Otherwise, it fails when compiling on mac. Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs #12199: remove macro redefinition warning in Windows Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: notify when the file is closed and has been modified so the file modified callback is run once Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: modify FileWatch test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: avoid waiting and instead block until callback is executed Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: fix Windows and MacOS executions. Fix Windows comparison warning Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: ensure that file modification callback is only run once Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: fix datarace in FileWatchTest Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Reload environment file information (eProsima#2205) * Refs #12199: refactor SystemInfo::get_env to use string instead of char* Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: set and get environment_file implementation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: get & set environment file test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: refactor get_env to read also from file. Update corresponding test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: remove unused parameter from callback. Fix test after rebase Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: add feature test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: feature implementation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: fix bug with FASTDDS_STATISTICS enabled Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: avoid including private header in public header file. Fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: apply suggestion of moving to RTPSDomainImpl all code related with file watcher Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: fix ServerClientEnvironmentSetUp test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: fix AddDiscoveryServerToListFromEnvironmentFile in Windows Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: disable AddDiscoveryServerToListFromEnvironmentFile in Apple Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: remove conflicting cases from ServerClientEnvironmentSetUp test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: remove unused member (fix Clang warning) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: apply review suggestion: move client_override flag to RTPSParticipantImpl Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: add review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: not run AddDiscoveryServerToListFromEnvironmentFile in Windows Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12199: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Fixed and improved StatisticsDataWriterQosTest. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com> Co-authored-by: Iker Luengo <ikerluengo@eprosima.com> Co-authored-by: IkerLuengo <57146230+IkerLuengo@users.noreply.github.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.