Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Statistics DataWriters in Discovery Server [12139] #2075

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Accept Statistics DataWriters in Discovery Server [12139] #2075

merged 1 commit into from
Jul 19, 2021

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jul 16, 2021

This PR should solve the logError described by @rsanchez15 in eProsima/Fast-DDS-statistics-backend#103 (review)

Signed-off-by: EduPonz eduardoponz@eprosima.com

@EduPonz
Refs 12139: Check if the writer is a statistics one
89e0022 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz requested a review from rsanchez15 July 16, 2021 10:42
rsanchez15
rsanchez15 approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the statistics backend and the monitor.

@MiguelCompany MiguelCompany merged commit bb33b86 into master Jul 19, 2021
@MiguelCompany MiguelCompany deleted the feature/server/accept-statistics-writers branch July 19, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsanchez15 rsanchez15 rsanchez15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EduPonz @rsanchez15 @MiguelCompany