init_monitor for eProsima Fast DDS Discovery Server networks #103

JLBuenoLopez · 2021-07-02T10:59:22Z

This PR implements and tests init_monitor overloads to start monitoring a Discovery Server network. The PR has added a new overload of init_monitor to provide the Server guidPrefix. If not provided, the default guidPrefix set in Fast DDS is used.

A future blackbox test where a couple of Discovery Servers networks are launched and then monitored is needed. This is put on hold until the first blackbox is merged, and we can build upon that.

codecov · 2021-07-02T11:22:26Z

Codecov Report

Merging #103 (bd93006) into main (210f669) will decrease coverage by 0.13%.
The diff coverage is 46.29%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   58.89%   58.75%   -0.14%     
==========================================
  Files          31       31              
  Lines        4111     4141      +30     
  Branches     2172     2193      +21     
==========================================
+ Hits         2421     2433      +12     
  Misses         50       50              
- Partials     1640     1658      +18

Impacted Files	Coverage Δ
src/cpp/StatisticsBackend.cpp	`45.07% <46.29%> (-0.50%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210f669...bd93006. Read the comment docs.

rsanchez15

Some of the bugs found when testing this functionality with the Fast DDS Monitor are:

When initialising a Discovery Server monitor, the domain name assigned is the GUID of the server. This causes that when trying to initialize a second monitor with the same GUID as the first one and different locators the backend throws the following exception:
```
Bad Parameter initializing monitor  A Domain with name '44.53.01.5f.45.50.52.4f.53.49.4d.41' already exists in the database
```
Neither the server nor the clients report statistics data despite having the FASTDDS_STATISTICS environment variable set correctly.

When a client is launched with all the statistics topics active, the server throws the following error trace:

2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.1.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.2.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.4.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.8.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.10.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.20.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.80.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.1.0.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.2.0.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.4.0.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.8.0.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.40.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.80.0.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.10.0.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.20.0.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.40.0.62 -> Function update
2021-07-14 12:09:54.648 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.1.0.0.62 -> Function update
2021-07-14 12:10:12.456 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.1.0.62 -> Function update
2021-07-14 12:10:12.457 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.8.0.62 -> Function update
2021-07-14 12:10:12.457 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.40.0.62 -> Function update
2021-07-14 12:10:12.457 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.20.0.62 -> Function update
2021-07-14 12:10:12.457 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.4.0.62 -> Function update
2021-07-14 12:10:12.457 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.80.62 -> Function update
2021-07-14 12:10:12.457 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.1.62 -> Function update
2021-07-14 12:10:12.457 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.2.0.62 -> Function update
2021-07-14 12:10:12.457 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.2.62 -> Function update
2021-07-14 12:10:12.457 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.10.0.62 -> Function update
2021-07-14 12:10:12.457 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.1.0.0.62 -> Function update
2021-07-14 12:10:12.457 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.4.62 -> Function update
2021-07-14 12:10:12.457 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.40.62 -> Function update
2021-07-14 12:10:12.458 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.20.62 -> Function update
2021-07-14 12:10:12.458 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.10.62 -> Function update
2021-07-14 12:10:12.458 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.80.0.62 -> Function update
2021-07-14 12:10:12.458 [DISCOVERY_DATABASE Error] Change is not a DATA(w|Uw|r|Ur): 1.f.8.48.80.4f.90.75.1.0.0.0.0.0.8.62 -> Function update

This does not occur when statistics are disabled on clients. This might come from the Discovery Server, in Fast DDS, but I'll leave it here to keep it in mind.

docs/rst/spelling_wordlist.txt

include/fastdds_statistics_backend/StatisticsBackend.hpp

…meter Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

…methods Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

…very server testing Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

JLBuenoLopez temporarily deployed to codecov July 2, 2021 10:59 Inactive

IkerLuengo force-pushed the feature/init_monitor_DS branch from 40a90a2 to a23dcf6 Compare July 5, 2021 10:31

IkerLuengo temporarily deployed to codecov July 5, 2021 10:31 Inactive

IkerLuengo had a problem deploying to codecov July 5, 2021 10:31 Failure

IkerLuengo marked this pull request as ready for review July 5, 2021 10:34

rsanchez15 mentioned this pull request Jul 8, 2021

Initialize monitor in a Discovery Server network [12028] eProsima/Fast-DDS-monitor#91

Merged

IkerLuengo force-pushed the feature/init_monitor_DS branch from a23dcf6 to 29dcbf2 Compare July 9, 2021 05:29

IkerLuengo had a problem deploying to codecov July 9, 2021 05:29 Failure

IkerLuengo temporarily deployed to codecov July 9, 2021 05:29 Inactive

IkerLuengo force-pushed the feature/init_monitor_DS branch from 29dcbf2 to 8d00e1a Compare July 9, 2021 05:35

IkerLuengo had a problem deploying to codecov July 9, 2021 05:35 Failure

IkerLuengo temporarily deployed to codecov July 9, 2021 05:35 Inactive

IkerLuengo force-pushed the feature/init_monitor_DS branch from 8d00e1a to 9dd7bb9 Compare July 12, 2021 09:52

IkerLuengo temporarily deployed to codecov July 12, 2021 09:52 Inactive

IkerLuengo temporarily deployed to codecov July 13, 2021 10:34 Inactive

rsanchez15 requested changes Jul 14, 2021

View reviewed changes

docs/rst/spelling_wordlist.txt Outdated Show resolved Hide resolved

include/fastdds_statistics_backend/StatisticsBackend.hpp Outdated Show resolved Hide resolved

include/fastdds_statistics_backend/StatisticsBackend.hpp Outdated Show resolved Hide resolved

EduPonz mentioned this pull request Jul 16, 2021

Accept Statistics DataWriters in Discovery Server [12139] eProsima/Fast-DDS#2075

Merged

IkerLuengo force-pushed the feature/init_monitor_DS branch from 9dd7bb9 to 05a53b4 Compare July 19, 2021 15:11

IkerLuengo temporarily deployed to codecov July 19, 2021 15:11 Inactive

IkerLuengo temporarily deployed to codecov July 19, 2021 15:12 Inactive

JLBuenoLopez added 6 commits July 20, 2021 16:36

Refs #11906: overload init_monitor to admit server guidPrefix as para…

7a808a3

…meter Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Refs #11906: discovery server init_monitor implementation

49ab7a8

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Refs #11906: unlock mutex in case of init_monitor failure

1e285de

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Refs #11906: extend init_monitor_failure tests to include overloaded …

8dc8f1a

…methods Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Refs #11906: generalize init_monitor tests and add init_monitor disco…

9bbefee

…very server testing Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Refs #11906: init_monitor negative texts, locator bad formatting

693b2b7

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

IkerLuengo added 5 commits July 20, 2021 16:44

Refs 11906. Use complete locator format

1128c25

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

Refs 11906. Test server with several locators

4c3a827

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

Refs 11906. Update documentation

15d2ef3

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

Refs 11906. uncrustify

fd039e7

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

Refs 11906. Requested changes

bd93006

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

IkerLuengo force-pushed the feature/init_monitor_DS branch from 05a53b4 to bd93006 Compare July 20, 2021 15:07

IkerLuengo temporarily deployed to codecov July 20, 2021 15:07 Inactive

IkerLuengo had a problem deploying to codecov July 20, 2021 15:07 Failure

IkerLuengo merged commit c03b47c into main Jul 21, 2021

IkerLuengo deleted the feature/init_monitor_DS branch July 21, 2021 06:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

init_monitor for eProsima Fast DDS Discovery Server networks #103

init_monitor for eProsima Fast DDS Discovery Server networks #103

JLBuenoLopez commented Jul 2, 2021 •

edited by IkerLuengo

Loading

codecov bot commented Jul 2, 2021 •

edited

Loading

rsanchez15 left a comment

init_monitor for eProsima Fast DDS Discovery Server networks #103

init_monitor for eProsima Fast DDS Discovery Server networks #103

Conversation

JLBuenoLopez commented Jul 2, 2021 • edited by IkerLuengo Loading

codecov bot commented Jul 2, 2021 • edited Loading

Codecov Report

rsanchez15 left a comment

Choose a reason for hiding this comment

JLBuenoLopez commented Jul 2, 2021 •

edited by IkerLuengo

Loading

codecov bot commented Jul 2, 2021 •

edited

Loading