Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10803] Collection of data and notification to listeners EDP_PACKETS #1948

Merged
merged 9 commits into from
May 10, 2021
Merged

[10803] Collection of data and notification to listeners EDP_PACKETS #1948

merged 9 commits into from
May 10, 2021

Conversation

MiguelBarro
Copy link
Contributor

It must be merged after #1946

@MiguelBarro MiguelBarro changed the title Collection of data and notification to listeners EDP_PACKETS [10803] Collection of data and notification to listeners EDP_PACKETS May 4, 2021
@MiguelBarro MiguelBarro temporarily deployed to codecov May 4, 2021 12:42 Inactive
MiguelCompany
MiguelCompany requested changes May 5, 2021
View reviewed changes
include/fastdds/rtps/common/EntityId_t.hpp Show resolved Hide resolved
src/cpp/rtps/participant/RTPSParticipantImpl.h Outdated Show resolved Hide resolved
src/cpp/statistics/rtps/StatisticsBase.cpp Outdated Show resolved Hide resolved
src/cpp/statistics/rtps/StatisticsBase.cpp Outdated Show resolved Hide resolved
@MiguelBarro MiguelBarro force-pushed the feature/statistics/edp_packets_impl branch from d0c4d07 to 2615262 Compare May 6, 2021 05:57
@MiguelBarro MiguelBarro requested a review from MiguelCompany May 6, 2021 05:57
@MiguelBarro MiguelBarro temporarily deployed to codecov May 6, 2021 05:58 Inactive
@MiguelBarro MiguelBarro force-pushed the feature/statistics/edp_packets_impl branch from 2615262 to cf4fabe Compare May 6, 2021 10:02
@MiguelBarro MiguelBarro temporarily deployed to codecov May 6, 2021 10:03 Inactive
@MiguelBarro MiguelBarro force-pushed the feature/statistics/edp_packets_impl branch 2 times, most recently from e0f1d1e to 46a85fa Compare May 6, 2021 12:24
MiguelCompany
MiguelCompany requested changes May 7, 2021
View reviewed changes
src/cpp/rtps/participant/RTPSParticipantImpl.h Outdated Show resolved Hide resolved
src/cpp/rtps/participant/RTPSParticipantImpl.h Outdated Show resolved Hide resolved
src/cpp/statistics/rtps/StatisticsBase.hpp Outdated Show resolved Hide resolved
src/cpp/statistics/rtps/StatisticsBase.hpp Show resolved Hide resolved
src/cpp/statistics/rtps/StatisticsBase.hpp Outdated Show resolved Hide resolved
@MiguelBarro MiguelBarro temporarily deployed to codecov May 7, 2021 09:15 Inactive
@MiguelBarro MiguelBarro requested a review from MiguelCompany May 7, 2021 09:37
MiguelCompany
MiguelCompany previously approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelBarro MiguelBarro force-pushed the feature/statistics/edp_packets_impl branch from 5cc57fc to a637d06 Compare May 10, 2021 05:42
@MiguelCompany MiguelCompany merged commit 19c50af into master May 10, 2021
@MiguelCompany MiguelCompany deleted the feature/statistics/edp_packets_impl branch May 10, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelBarro @MiguelCompany