Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10802] Collection of data and notification to listeners PDP_PACKETS #1946

Merged
merged 6 commits into from
May 6, 2021

Conversation

MiguelBarro
Copy link
Contributor

There is a little piggyback preventing the dds layer statistics endpoints from been instrumented from the rtps layer.

src/cpp/rtps/participant/RTPSParticipantImpl.h Outdated Show resolved Hide resolved
src/cpp/statistics/rtps/StatisticsBase.cpp Outdated Show resolved Hide resolved
src/cpp/statistics/types/typesPubSubTypes.cxx Outdated Show resolved Hide resolved
@MiguelBarro MiguelBarro temporarily deployed to codecov May 5, 2021 12:15 Inactive
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany temporarily deployed to codecov May 6, 2021 08:16 Inactive
@MiguelCompany
Copy link
Member

@richiprosima Please test this 🤞

@MiguelCompany MiguelCompany merged commit b68633c into master May 6, 2021
@MiguelCompany MiguelCompany deleted the feature/statistics/pdp_packets_impl branch May 6, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants