-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HISTORY2HISTORY_LATENCY test and implementation [10789] #1941
HISTORY2HISTORY_LATENCY test and implementation [10789] #1941
Conversation
fcffeb7
to
a39aa34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The participant doesn't need to instrument the writers in order to notify this callback. Please remove from the mask in:
constexpr uint32_t writers_maks = HISTORY2HISTORY_LATENCY \ |
Add the new callback to the comments in:
Fast-DDS/test/unittest/statistics/rtps/RTPSStatisticsTests.cpp
Lines 519 to 527 in 8def391
/* | |
* This test checks RTPSParticipant, RTPSWriter and RTPSReader statistics module related APIs. | |
* - RTPS_SENT callbacks are performed | |
* - DATA_COUNT callbacks are performed for DATA submessages | |
* - RESENT_DATAS callbacks are performed for DATA submessages demanded by the readers | |
* - ACKNACK_COUNT callbacks are performed | |
* - HEARBEAT_COUNT callbacks are performed | |
* - SAMPLE_DATAS callbacks are performed | |
*/ |
Fast-DDS/test/unittest/statistics/rtps/RTPSStatisticsTests.cpp
Lines 652 to 657 in 8def391
/* | |
* This test checks RTPSParticipant, RTPSWriter and RTPSReader statistics module related APIs. | |
* - participant listeners management with late joiners | |
* - DATA_COUNT callbacks with DATA_FRAGS are performed | |
* - NACK_FRAG callbacks assessment | |
*/ |
WriterReaderData notification; | ||
notification.reader_guid(to_statistics_type(get_guid())); | ||
notification.writer_guid(to_statistics_type(writer_guid)); | ||
notification.data(ns * 1.0f); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not plainly:
notification.data(float(ns));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with static_cast
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
a39aa34
to
9a1348b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.