Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HISTORY2HISTORY_LATENCY test and implementation [10789] #1941

Merged
merged 5 commits into from
May 11, 2021

Conversation

MiguelCompany
Copy link
Member

No description provided.

@MiguelCompany MiguelCompany force-pushed the feature/statistics/rtps/history-latency branch from fcffeb7 to a39aa34 Compare May 4, 2021 07:25
@MiguelCompany MiguelCompany temporarily deployed to codecov May 4, 2021 07:32 Inactive
@MiguelCompany MiguelCompany requested a review from MiguelBarro May 7, 2021 09:29
Copy link
Contributor

@MiguelBarro MiguelBarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The participant doesn't need to instrument the writers in order to notify this callback. Please remove from the mask in:

constexpr uint32_t writers_maks = HISTORY2HISTORY_LATENCY \

Add the new callback to the comments in:
/*
* This test checks RTPSParticipant, RTPSWriter and RTPSReader statistics module related APIs.
* - RTPS_SENT callbacks are performed
* - DATA_COUNT callbacks are performed for DATA submessages
* - RESENT_DATAS callbacks are performed for DATA submessages demanded by the readers
* - ACKNACK_COUNT callbacks are performed
* - HEARBEAT_COUNT callbacks are performed
* - SAMPLE_DATAS callbacks are performed
*/

/*
* This test checks RTPSParticipant, RTPSWriter and RTPSReader statistics module related APIs.
* - participant listeners management with late joiners
* - DATA_COUNT callbacks with DATA_FRAGS are performed
* - NACK_FRAG callbacks assessment
*/

WriterReaderData notification;
notification.reader_guid(to_statistics_type(get_guid()));
notification.writer_guid(to_statistics_type(writer_guid));
notification.data(ns * 1.0f);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not plainly:

notification.data(float(ns));

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with static_cast

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the feature/statistics/rtps/history-latency branch from a39aa34 to 9a1348b Compare May 11, 2021 06:58
@MiguelCompany MiguelCompany temporarily deployed to codecov May 11, 2021 06:59 Inactive
@MiguelCompany MiguelCompany requested a review from MiguelBarro May 11, 2021 07:02
Copy link
Contributor

@MiguelBarro MiguelBarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit de8e8ec into master May 11, 2021
@MiguelCompany MiguelCompany deleted the feature/statistics/rtps/history-latency branch May 11, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants