Refs 10789. Adressed review comments.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
eProsima · May 11, 2021 · 9a1348b · 9a1348b
1 parent 9f42fee
commit 9a1348b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/cpp/statistics/rtps/StatisticsBase.cpp b/src/cpp/statistics/rtps/StatisticsBase.cpp
@@ -135,8 +135,7 @@ bool StatisticsParticipantImpl::are_writers_involved(
 {
     using namespace fastdds::statistics;
 
-    constexpr uint32_t writers_maks = HISTORY2HISTORY_LATENCY \
-            | PUBLICATION_THROUGHPUT \
+    constexpr uint32_t writers_maks = PUBLICATION_THROUGHPUT \
             | RESENT_DATAS \
             | HEARTBEAT_COUNT \
             | GAP_COUNT \

diff --git a/src/cpp/statistics/rtps/reader/StatisticsReaderImpl.cpp b/src/cpp/statistics/rtps/reader/StatisticsReaderImpl.cpp
@@ -74,7 +74,7 @@ void StatisticsReaderImpl::on_data_notify(
     WriterReaderData notification;
     notification.reader_guid(to_statistics_type(get_guid()));
     notification.writer_guid(to_statistics_type(writer_guid));
-    notification.data(ns * 1.0f);
+    notification.data(static_cast<float>(ns));
 
     // Perform the callback
     Data data;

diff --git a/test/unittest/statistics/rtps/RTPSStatisticsTests.cpp b/test/unittest/statistics/rtps/RTPSStatisticsTests.cpp
@@ -523,6 +523,7 @@ TEST_F(RTPSStatisticsTests, statistics_rpts_listener_management)
 /*
  * This test checks RTPSParticipant, RTPSWriter and RTPSReader statistics module related APIs.
  * - RTPS_SENT callbacks are performed
+ * - HISTORY2HISTORY_LATENCY callbacks are performed
  * - DATA_COUNT callbacks are performed for DATA submessages
  * - RESENT_DATAS callbacks are performed for DATA submessages demanded by the readers
  * - ACKNACK_COUNT callbacks are performed
@@ -662,6 +663,7 @@ TEST_F(RTPSStatisticsTests, statistics_rpts_listener_callbacks)
 /*
  * This test checks RTPSParticipant, RTPSWriter and RTPSReader statistics module related APIs.
  * - participant listeners management with late joiners
+ * - HISTORY2HISTORY_LATENCY callbacks are performed
  * - DATA_COUNT callbacks with DATA_FRAGS are performed
  * - NACK_FRAG callbacks assessment
  */