Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable data sharing in LatencyTest by default #1904

Merged

Conversation

JakubSosnovec
Copy link
Contributor

Fixes #1898

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Please fix DCO.

Signed-off-by: Jakub Sosnovec <jakub.sosnovec@nxp.com>
@JakubSosnovec JakubSosnovec force-pushed the bugfix/data-sharing-latency-test branch from e222752 to e3d0b93 Compare April 14, 2021 12:34
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failures seem unrelated.

@MiguelCompany MiguelCompany merged commit 8b3cfaa into eProsima:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data sharing should be disabled in LatencyTest benchmark without --data_sharing flag
2 participants