Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data sharing should be disabled in LatencyTest benchmark without --data_sharing flag #1898

Closed
JakubSosnovec opened this issue Apr 8, 2021 · 1 comment · Fixed by #1904
Closed

Comments

@JakubSosnovec
Copy link
Contributor

When no XML profile is passed to the LatencyTest benchmark, data sharing policy is set to automatic by default. This will mean that data sharing is enabled regardless whether the --data_sharing command line flag is passed to the program or not.

Expected Behavior

Data sharing policy should be disabled when --data_sharing command line flag is not passed.

Current Behavior

Data sharing policy is automatic (and thus enabled) even if --data_sharing command line flag is not passed.

Steps to Reproduce

  1. Run LatencyTest publisher and subscriber on the same device (to benchmark shared memory transport).
  2. Try with passing --data_sharing flag.
  3. Try without passsing --data_sharing flag.
  4. Observe that the performance results are the same.

Suggested fix

Explicitly set the DataSharingQosPolicy to "off" whenever the command line flag is not passed in. Could be done here: https://github.com/eProsima/Fast-DDS/blob/master/test/performance/latency/LatencyTestPublisher.cpp#L274 and https://github.com/eProsima/Fast-DDS/blob/master/test/performance/latency/LatencyTestSubscriber.cpp#L226

@MiguelCompany
Copy link
Member

@JakubSosnovec Would you mind doing the changes yourself and submitting a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants