Fix read_next_sample and take_next_sample <2.2.x> [11145] #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a port of #1732 from <master> to <2.2.x> * Refs 10476. Fix on DataReaderTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. Added xxx_next_sample tests to DataReaderTests.read_unread Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. Strict real-time on read_or_take. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. Using LoanableTypedCollection<SampleInfo> on ReadTakeCommand and DataReaderLoanManager. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. Use ReadTakeCommand on take_next_sample. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. Use ReadTakeCommand on read_next_sample via read_or_take_next_sample. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. Adapt tests to new behavior of take Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10476. Added method get_first_change_with_minimum_ts to ReaderHistory. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. Add new method to mock. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. PubSubReader::last_seq is now a map for each instance. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. Added UserAllocatedSequence. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. Added take_first_data to PubSubReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. Using take_first_data on LifespanQos blackbox test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10476. Solve build error on non-windows platforms. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 10480. Apply suggestions from code review Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: IkerLuengo <57146230+IkerLuengo@users.noreply.github.com> Co-authored-by: Iker Luengo <ikerluengo@eprosima.com> Co-authored-by: IkerLuengo <57146230+IkerLuengo@users.noreply.github.com> Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
JLBuenoLopez
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
LGTM!
CI failures are unrelated. Discovery server build error is fixed in #1811.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #1732 from to <2.2.x>