Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10778] <2.2.x> Backport discovery service fixes #1811

Merged
merged 5 commits into from
Apr 23, 2021
Merged

[10778] <2.2.x> Backport discovery service fixes #1811

merged 5 commits into from
Apr 23, 2021

Conversation

JLBuenoLopez
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez commented Mar 8, 2021 •
edited
Loading

This PR backports:

Signed-off-by: JLBuenoLopez-eProsima joseluisbueno@eprosima.com

@JLBuenoLopez
Refs #10778: backport discovery CLI verbosity to 2.2.x
25ec9d1 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez JLBuenoLopez changed the title Refs #10778: backport discovery CLI verbosity to 2.2.x [10778] <2.2.x> Backport discovery CLI verbosity Mar 8, 2021
@JLBuenoLopez
Refs #10778: uncrustify
7119116 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #10778: fix GuidPrefix serialization
fb5c836 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez JLBuenoLopez changed the title [10778] <2.2.x> Backport discovery CLI verbosity [10778] <2.2.x> Backport discovery service fixes Mar 9, 2021
@JLBuenoLopez JLBuenoLopez mentioned this pull request Mar 9, 2021
Merged
@JLBuenoLopez
Refs #10778: backport super client feature to 2.2.x
8c4169b 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs 10778: uncrustify
24b94ac 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Copy link
Contributor Author

CI failures seem unrelated. Discovery Server test failures are known to be flaky.

MiguelCompany
MiguelCompany approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unrelated failures.

@MiguelCompany MiguelCompany merged commit c68fbd3 into 2.2.x Apr 23, 2021
@MiguelCompany MiguelCompany deleted the feature/2.2.x-increase_ds_cli_verbosity branch April 23, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JLBuenoLopez @MiguelCompany