-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more verbosity to discovery CLI [10611] #1764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
This was referenced Feb 17, 2021
IkerLuengo
suggested changes
Feb 19, 2021
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
IkerLuengo
previously approved these changes
Feb 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Waiting for CI results
@EduPonz Linter errors here |
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
EduPonz
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
no-aarch
Skip build & test for aarch64
labels
Feb 23, 2021
@richiprosima please test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-aarch
Skip build & test for aarch64
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more verbosity to the stdout of the
fastdds discovery
command. Example:This way, creating an XML file for CLIENTS connecting to the SERVER is easier, since the prefix is clearly stated. For doing this, a
<<
operator has been added for theDiscoveryProtocol
enum. Furthermore, the<<
operator for theGuidPrefix
has been enhanced, so that the bytes are always showed as two digits, adding a preceding 0 if necessary.It is important to note the the default GUID prefix for the server has changed. The following schema is applied now:
44.53.<server_id>.5f.45.50.52.4f.53.49.4d.41
, which translated into ASCII asDS<id_in_hex>_EPROSIMA
.Finally, the participant type property has been added to the
SIMPLE
participant's DATA(p)s