Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more verbosity to discovery CLI [10611] #1764

Merged
merged 5 commits into from
Feb 26, 2021

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Feb 16, 2021

This PR adds more verbosity to the stdout of the fastdds discovery command. Example:

### Server is running ###
  Server ID:          0
  Server GUID prefix: 44.53.00.5f.45.50.52.4f.53.49.4d.41
  Server Address:     UDPv4:[127.0.0.1]:11811
  Participant Type    SERVER
### Server shut down ###

This way, creating an XML file for CLIENTS connecting to the SERVER is easier, since the prefix is clearly stated. For doing this, a << operator has been added for the DiscoveryProtocol enum. Furthermore, the << operator for the GuidPrefix has been enhanced, so that the bytes are always showed as two digits, adding a preceding 0 if necessary.

It is important to note the the default GUID prefix for the server has changed. The following schema is applied now:

  • 44.53.<server_id>.5f.45.50.52.4f.53.49.4d.41, which translated into ASCII as DS<id_in_hex>_EPROSIMA.

Finally, the participant type property has been added to the SIMPLE participant's DATA(p)s

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
IkerLuengo
IkerLuengo previously approved these changes Feb 19, 2021
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Waiting for CI results

@MiguelCompany
Copy link
Member

@EduPonz Linter errors here

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany added this to the v2.3.0 milestone Feb 22, 2021
@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. no-aarch Skip build & test for aarch64 labels Feb 23, 2021
@EduPonz
Copy link
Author

EduPonz commented Feb 26, 2021

@richiprosima please test this

@EduPonz EduPonz merged commit 22aed08 into master Feb 26, 2021
@EduPonz EduPonz deleted the feature/increase_ds_cli_verbosity branch February 26, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-aarch Skip build & test for aarch64 ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants