Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Writer history behavior when there are no matched readers <1.8.x> [9033] #1333

Merged
merged 7 commits into from
Oct 7, 2020

Conversation

lauramg15
Copy link
Contributor

This is a backport of #1324 to 1.8.x

@lauramg15 lauramg15 force-pushed the bugfix/backport_1324_1.8.x branch from 0c79c9a to c215831 Compare August 5, 2020 10:41
MiguelCompany
MiguelCompany previously approved these changes Aug 5, 2020
MiguelCompany
MiguelCompany previously approved these changes Aug 6, 2020
MiguelCompany
MiguelCompany previously approved these changes Aug 6, 2020
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany
Copy link
Member

@laura-eprosima Could you please rebase this?

Laura Martin added 6 commits October 6, 2020 11:41
… no readers

Signed-off-by: Laura Martin <laura@eprosima.com>
Signed-off-by: Laura Martin <laura@eprosima.com>
Signed-off-by: Laura Martin <laura@eprosima.com>
Signed-off-by: Laura Martin <laura@eprosima.com>
* When there are no readers all the samples are set as acknowledged so that the old changes can be removed and replaced with new ones.

Signed-off-by: Laura Martin <laura@eprosima.com>
Signed-off-by: Laura Martin <laura@eprosima.com>
Signed-off-by: Laura Martin <laura@eprosima.com>
@richiware
Copy link
Member

richiware commented Oct 7, 2020

Build status:

  • Linux Build Status
    • CI upgraded to Ubuntu 20.04, but code on ros2_eloquent supports Ubuntu 18.04
    • Checked locally on an Ubuntu 18.04 docker and all tests pass.
  • Mac Build Status
  • Windows Build Status
    • Warning on VS 2019, which is unsupported on 1.8.x

@MiguelCompany MiguelCompany merged commit 6ac5365 into 1.8.x Oct 7, 2020
@MiguelCompany MiguelCompany deleted the bugfix/backport_1324_1.8.x branch October 7, 2020 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants