-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Writer history behavior when there are no matched readers <1.8.x> [9033] #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauramg15
force-pushed
the
bugfix/backport_1324_1.8.x
branch
from
August 5, 2020 10:41
0c79c9a
to
c215831
Compare
MiguelCompany
previously approved these changes
Aug 5, 2020
MiguelCompany
previously approved these changes
Aug 6, 2020
MiguelCompany
previously approved these changes
Aug 6, 2020
@laura-eprosima Could you please rebase this? |
… no readers Signed-off-by: Laura Martin <laura@eprosima.com>
Signed-off-by: Laura Martin <laura@eprosima.com>
Signed-off-by: Laura Martin <laura@eprosima.com>
Signed-off-by: Laura Martin <laura@eprosima.com>
* When there are no readers all the samples are set as acknowledged so that the old changes can be removed and replaced with new ones. Signed-off-by: Laura Martin <laura@eprosima.com>
Signed-off-by: Laura Martin <laura@eprosima.com>
lauramg15
force-pushed
the
bugfix/backport_1324_1.8.x
branch
from
October 6, 2020 09:42
598c00b
to
e472838
Compare
Signed-off-by: Laura Martin <laura@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1324 to 1.8.x