[21286] Improve CI workflows in master #216

JesusPoderoso · 2024-07-11T10:16:24Z

Description

This PR improves the CI workflows, making them as similar as possible to the Fast DDS workflows.
It also introduces a braching model refactor, similiar as the performed in Fast DDS repository.

It is on top of (and must be merged after) this PR:

[20414] Add PR template #203

Note: While backporting this PR, please ensure the following changes:

Remove nightly jobs
Update ubuntu-ci.yml, mac-ci.yml and windows-ci.yml files with the proper fallback branches
Maintain reduced version of the RELEASE_SUPPORT.md (only reference to master links)
Create mirror job on 1.1.x brach (targetting 1.x)
Fast CDR 1.0.x requires building on ubuntu-20.04

@Mergifyio backport 2.2.x 1.1.x 1.0.x

Contributor Checklist

Commit messages follow the project guidelines.
N/A The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
N/A Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: CI pass and failing tests are unrelated with the changes.

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

richiprosima · 2024-07-11T11:57:51Z

Build status:

Linux
Mac
Windows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

EduPonz · 2024-07-11T14:24:53Z

@Mergifyio backport 2.2.x 1.1.x 1.0.x

mergify · 2024-07-11T14:25:13Z

backport 2.2.x 1.1.x 1.0.x

✅ Backports have been created

#217 [21286] Improve CI workflows in master (backport #216) has been created for branch 2.2.x
#218 [21286] Improve CI workflows in master (backport #216) has been created for branch 1.1.x but encountered conflicts
#219 [21286] Improve CI workflows in master (backport #216) has been created for branch 1.0.x but encountered conflicts

* Refs #21286: Add Ubuntu CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add Windows CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add MacOS CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Remove previous job Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Update PR template Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add missing dependency Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Fix colcon test warning Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add RELEASE_SUPPORT.md Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Fix labels Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Try to fix windows CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Include GitHub CI badges in readme Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 203725d)

* Refs #21286: Add Ubuntu CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add Windows CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add MacOS CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Remove previous job Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Update PR template Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add missing dependency Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Fix colcon test warning Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add RELEASE_SUPPORT.md Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Fix labels Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Try to fix windows CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Include GitHub CI badges in readme Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 203725d) # Conflicts: # .github/pull_request_template.md # .github/workflows/config/build.meta # .github/workflows/fastcdr-test.yml

* Refs #21286: Add Ubuntu CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add Windows CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add MacOS CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Remove previous job Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Update PR template Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add missing dependency Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Fix colcon test warning Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add RELEASE_SUPPORT.md Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Fix labels Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Try to fix windows CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Include GitHub CI badges in readme Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 203725d)

* Refs #21286: Add Ubuntu CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add Windows CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add MacOS CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Remove previous job Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Update PR template Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add missing dependency Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Fix colcon test warning Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Add RELEASE_SUPPORT.md Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Fix labels Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Try to fix windows CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21286: Include GitHub CI badges in readme Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 203725d) Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>

JesusPoderoso added 10 commits July 9, 2024 10:30

Refs #21286: Add Ubuntu CI

58ed9a2

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #21286: Add Windows CI

d3cb838

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #21286: Add MacOS CI

577545f

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #21286: Remove previous job

90ceff7

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #21286: Update PR template

0c31c70

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #21286: Add missing dependency

c39e86e

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #21286: Fix colcon test warning

6ce37d7

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #21286: Add RELEASE_SUPPORT.md

8901c9b

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #21286: Apply rev suggestions

c8b7199

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #21286: Fix labels

419224e

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso added this to the v3.0.0 milestone Jul 11, 2024

JesusPoderoso self-assigned this Jul 11, 2024

JesusPoderoso requested a review from EduPonz July 11, 2024 10:16

github-actions bot added the ci-pending label Jul 11, 2024

JesusPoderoso mentioned this pull request Jul 11, 2024

[21286] Improve CI workflows in master #213

Closed

7 tasks

JesusPoderoso modified the milestones: v3.0.0, v2.2.3 Jul 11, 2024

JesusPoderoso force-pushed the feature/21286 branch from 67672d0 to c9d13ff Compare July 11, 2024 10:25

JesusPoderoso requested review from EduPonz and removed request for EduPonz July 11, 2024 10:25

Refs #21286: Try to fix windows CI

afdb31c

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso force-pushed the feature/21286 branch from c9d13ff to afdb31c Compare July 11, 2024 10:51

JesusPoderoso requested review from EduPonz and removed request for EduPonz July 11, 2024 10:51

EduPonz previously approved these changes Jul 11, 2024

View reviewed changes

Refs #21286: Include GitHub CI badges in readme

f2fadd9

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso dismissed EduPonz’s stale review via f2fadd9 July 11, 2024 14:23

JesusPoderoso requested a review from EduPonz July 11, 2024 14:23

EduPonz approved these changes Jul 11, 2024

View reviewed changes

EduPonz merged commit 203725d into master Jul 11, 2024
6 of 11 checks passed

EduPonz deleted the feature/21286 branch July 11, 2024 14:24

mergify bot mentioned this pull request Jul 11, 2024

[21286] Improve CI workflows in master (backport #216) #217

Merged

7 tasks

mergify bot mentioned this pull request Jul 11, 2024

[21286] Improve CI workflows in master (backport #216) #218

Merged

7 tasks

mergify bot mentioned this pull request Jul 11, 2024

[21286] Improve CI workflows in master (backport #216) #219

Merged

7 tasks

JesusPoderoso added ready-to-merge and removed ci-pending labels Jul 11, 2024

github-actions bot added the ci-pending label Jul 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[21286] Improve CI workflows in master #216

[21286] Improve CI workflows in master #216

JesusPoderoso commented Jul 11, 2024 •

edited by EduPonz

Loading

richiprosima commented Jul 11, 2024

EduPonz commented Jul 11, 2024

mergify bot commented Jul 11, 2024 •

edited

Loading

[21286] Improve CI workflows in master #216

[21286] Improve CI workflows in master #216

Conversation

JesusPoderoso commented Jul 11, 2024 • edited by EduPonz Loading

Description

Contributor Checklist

Reviewer Checklist

richiprosima commented Jul 11, 2024

EduPonz commented Jul 11, 2024

mergify bot commented Jul 11, 2024 • edited Loading

✅ Backports have been created

JesusPoderoso commented Jul 11, 2024 •

edited by EduPonz

Loading

mergify bot commented Jul 11, 2024 •

edited

Loading