Release Merge #279
Merged
Release Merge #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oScreen point conversions, missing xml comments in JsModuleManager
FeatureLayer Client-side Graphics method fixes
Fix for snapping back to param-defined extent on mouse wheel
| /// </summary> | ||
| [Parameter] | ||
| [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] | ||
| public bool? Visible { get; set; } |
There was a problem hiding this comment.
so it default to true in JS if its null?
There was a problem hiding this comment.
Yes, using the copyValuesIfExist pattern in the TypeScript, we only set this if the user does, otherwise we leave it unset and the ArcGIS defaults take over.
AndersenBell
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
New Features
Bug Fixes
FeatureLayerwith an emptySourceCannot Create an Empty FeatureLayer for Client-side Graphics #275ExtentMapView Zoom Resets when OnViewRendered Defined on View #276View.ToScreenandView.HitTestpoint calculations bugLabel.LabelPlacement(see Breaking Change below)FeatureLayer.Add(graphic)Breaking Change
Label.LabelPlacementwith an enum