FeatureLayer Client-side Graphics method fixes #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| catch (Exception ex) | ||
| { | ||
| Console.WriteLine(ex); |
There was a problem hiding this comment.
should this be a console log?
There was a problem hiding this comment.
In general, I've never hooked up GeoBlazor to ILogger, although I suppose we could/should. Since it's a library, I wasn't sure how I felt about "pushing" log messages to someone's logger implementation? Anyways, that seems like it should be it's own library-wide gissue. Let's talk about it more.
AndersenBell
approved these changes
Dec 18, 2023
…oScreen point conversions, missing xml comments in JsModuleManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #275
Sourceparameter like below (C#12 syntax). This makes it possible to start with an empty layer and then add graphics later programmatically.layerview-create, and thus isn't "registered" in GeoBlazor with a JSObjectReference. FixedApplyEditsto also callLoadfirst if the object ref isn't set.FeatureLayer.Add(Graphic graphic)andFeatureLayer.Remove(Graphic graphic)methods if these are called after the layer is rendered, because ArcGIS Feature Layers do not support updating graphics this way.ImageryLayerand the related renderers to remove broken code that was either not converting correctly in TypeScript, or was trying to set read-only fieldsLabel.LabelPlacementto be an enum instead of a string. While this is technically a breaking change, I did discover a bug when the value would round-trip from ArcGIS, where ArcGIS returned values likeesriServerPointLabelPlacementAboveCenter, so this also fixes that bug.Layer.LoadtestRunner.jsto use a better injection pattern for extending GeoBlazor.