Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Merge #226

Merged
merged 10 commits into from
Sep 12, 2023
Merged

Release Merge #226

merged 10 commits into from
Sep 12, 2023

Conversation

TimPurdum
Copy link
Collaborator

  • Update links in Samples home page
  • Added a new sample for clicking to add a point
  • Fixes for popup templates and popup actions bugs like PopupAction Investigation #222

}

.pro a {
color: gold!important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just poking in to say generally speaking, it's best not to use !important most of the time in CSS. Specifying the class and element like you did here should be enough to ensure no other rules in this file take priority. Is there maybe another reason !important is needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agnesstelmach you are absolutely correct, and it was a shortcut months ago that I used instead of taking the time to figure out why it didn't work without it. I will try to revisit soon, or feel free when you're working in GB to update!

"lockfileVersion": 2,
"requires": true,
"packages": {
"": {
"name": "dymaptic.GeoBlazor.Core",
"version": "2.3.0",
"version": "2.3.1-beta-1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference between 2.3.1-beta-1 and everywhere else that has 2.3.2?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json should generate on build from package.json, guess I forgot to do a build here, will correct before merging!

@TimPurdum TimPurdum merged commit 457cd85 into main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants