Bug/222 popup action update #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| if (layer is GraphicsLayer graphicsLayer) |
There was a problem hiding this comment.
could this be an else if?
There was a problem hiding this comment.
It could. I was thinking it doesn't change the flow at all (I use this pattern when return is in each if), but in this case, you could find a FeatureLayer, not find the popup, and then have to ask again what it's layer type is, so you're right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #222
idto thePopupTemplateSerializationRecordfor protobufgraphic.jsonso the JS side has it for deserializationlookupfunction injsbuilder.tsandMapView.razor.csthat finds a missing dotnet object referenceActionButtonandActionToggle