add comment and log for rev share err case

Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
dydxprotocol · Jun 27, 2024 · d6b1e71 · d6b1e71
1 parent 49942c3
commit d6b1e71
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/protocol/x/subaccounts/keeper/transfer.go b/protocol/x/subaccounts/keeper/transfer.go
@@ -237,6 +237,11 @@ func (k Keeper) DistributeFees(
 		ctx,
 		perpetual.Params.MarketId,
 	)
+	// Note: The likelihood of this error is very low, and not getting the rev share should not
+	// prevent the trade from going through. Therefore, we log the error and continue
+	if err != nil {
+		log.ErrorLog(ctx, "DistributeFees: failed to get market mapper revenue share", "err", err)
+	}
 	if err == nil && revShareAddr != nil {
 		if revSharePpm >= 1e6 {
 			log.ErrorLog(