address nits and fix tests

Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
dydxprotocol · Jun 27, 2024 · 49942c3 · 49942c3
1 parent 6c0d0dc
commit 49942c3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/protocol/x/revshare/keeper/grpc_query_marketmapper_revshare_details_test.go b/protocol/x/revshare/keeper/grpc_query_marketmapper_revshare_details_test.go
@@ -40,5 +40,5 @@ func TestQueryMarketMapperRevShareDetailsFailure(t *testing.T) {
 			MarketId: 42,
 		},
 	)
-	require.ErrorContains(t, err, "MarketMapperRevShareDetails not found for marketId: 42")
+	require.ErrorIs(t, err, types.ErrMarketMapperRevShareDetailsNotFound)
 }
diff --git a/protocol/x/revshare/keeper/revshare_test.go b/protocol/x/revshare/keeper/revshare_test.go
@@ -46,7 +46,7 @@ func TestGetMarketMapperRevShareDetailsFailure(t *testing.T) {
 
 	// Get the rev share details for non-existent market
 	_, err := k.GetMarketMapperRevShareDetails(ctx, 42)
-	require.ErrorContains(t, err, "MarketMapperRevShareDetails not found for marketId: 42")
+	require.ErrorIs(t, err, types.ErrMarketMapperRevShareDetailsNotFound)
 }
 
 func TestCreateNewMarketRevShare(t *testing.T) {
@@ -115,7 +115,7 @@ func TestGetMarketMapperRevenueShareForMarket(t *testing.T) {
 
 			expectedErr: types.ErrMarketMapperRevShareDetailsNotFound,
 		},
-		// TODO: investigate why tApp blocktime doesn't translate to ctx.BlockTime()
+		// TODO (TRA-455): investigate why tApp blocktime doesn't translate to ctx.BlockTime()
 		//"expired market rev share": {
 		//	revShareParams: types.MarketMapperRevenueShareParams{
 		//		Address:         constants.AliceAccAddress.String(),

diff --git a/protocol/x/subaccounts/keeper/transfer.go b/protocol/x/subaccounts/keeper/transfer.go
@@ -258,7 +258,7 @@ func (k Keeper) DistributeFees(
 	feeCollectorShare := new(big.Int).Sub(quantums, marketMapperShare)
 
 	// Transfer fees to the market mapper
-	// TODO: add monitoring to record the amount of fees transferred to the market mapper
+	// TODO (TRA-444): add monitoring to record the amount of fees transferred to the market mapper
 	if err := k.TransferFees(
 		ctx,
 		assetId,