Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPE-191 Post migration cleanup #4648

Merged
merged 13 commits into from
Oct 24, 2023
  •  
  •  
  •  
15 changes: 0 additions & 15 deletions dbt_project.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double checked these three being removed:

  • oneplanet is good, this PR also removes everything in that directory (all legacy stuff, new stuff moved to _sector/nft/ as expected
  • nftearth is good, same story as above
  • quix has been moved to new directory as well, but the schema / source file remain in old directory models/quix/optimism/ rather than new directory models/_sector/nft/ -- or maybe just dupes?
    • @0xRobin can you double check these schema / source files for quix and clean up in follow-up PR as needed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I'll move the schema/sources over. 👍

Original file line number Diff line number Diff line change
Expand Up @@ -371,11 +371,6 @@ models:
bnb:
+schema: babyswap_bnb

oneplanet:
+schema: oneplanet
polygon:
+schema: oneplanet_polygon

opensea:
+schema: opensea
ethereum:
Expand Down Expand Up @@ -1002,11 +997,6 @@ models:
ethereum:
+schema: nexusmutual_ethereum

quix:
+schema: quix
optimism:
+schema: quix_optimism

zeroex:
+schema: zeroex
ethereum:
Expand Down Expand Up @@ -1259,11 +1249,6 @@ models:
ethereum:
+schema: oneinch_ethereum

nftearth:
+schema: nftearth
optimism:
+schema: nftearth_optimism

pooltogether:
+schema: pooltogether
ethereum:
Expand Down
63 changes: 0 additions & 63 deletions macros/dune/create_seed_as.sql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that we had to override these for spark/databricks, but not trino, for s3 location stuff mostly it seems. these macro removals will be good first candidates if anything breaks

This file was deleted.

74 changes: 0 additions & 74 deletions macros/dune/create_table_as.sql

This file was deleted.

19 changes: 0 additions & 19 deletions macros/dune/macros_schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,6 @@ macros:
type: column name or expression
description: "Node"

- name: databricks__create_table_as
description: >
Overrides databricks table macro to use an s3 bucket set by a dbt var set by an env variable.
Macros do not allow access to env variables and therefore we must set use the dbt_project file
to set the dbt var with the env var. If no env var is set, no location will be used. Env vars
must be set by Dune employees but no change is needed for wizards

- name: spark__create_table_as
description: >
Same but overrides macro for spark package

- name: databricks__create_csv_table
description: >
Same as create_table_as but for seeds with databricks package

- name: spark__create_csv_table
description: >
Same as create_table_as but for seeds with spark package

- name: is_incremental
description: >
Overrides the core is_incremental marco to allow the usage of a force-incremental command line variable.
Expand Down
50 changes: 0 additions & 50 deletions macros/models/_sector/erc4337/erc4337_userops_basics_legacy.sql

This file was deleted.

This file was deleted.

Loading