SPE-191 Post migration cleanup

[couralex6]

Removed:

• models/*_legacy.sql
• macros/*_legacy.sql
  • create_seed_as.sql + create_table_as.sql (spark specific)
• seeds/*_legacy.csv
• tests/*_legacy.sql

[jeff-dude]

@couralex6 sorry need to cancel workflow here for a sec :)

there's a large PR running and it's causing failures in other spots. let's give it a few min

[jeff-dude]

@couralex6 sorry need to cancel workflow here for a sec :)

there's a large PR running and it's causing failures in other spots. let's give it a few min

for reference:
https://github.com/duneanalytics/spellbook/actions/runs/6591243292/job/17909457507?pr=4582

[couralex6]

Ready to go @jeff-dude !

[jeff-dude]

Ready to go @jeff-dude !

okay, let's potentially regroup this afternoon to see if we can merge. i want to prioritize a few other things first

[couralex6]

Also removed:
models/nftearth/optimism/nftearth_optimism_schema.yml
models/oneplanet/polygon/oneplanet_polygon_schema.yml

Moved to _sector/nft/old/platforms/:

• models/quix/optimism/quix_optimism_schema.yml
• models/quix/optimism/quix_optimism_sources.yml

Removed old entries from dbt_project.yml

[couralex6]

Good to go now! @jeff-dude

[jeff-dude]

approving with couple comments below for future context

[jeff-dude]

double checked these three being removed:

• oneplanet is good, this PR also removes everything in that directory (all legacy stuff, new stuff moved to _sector/nft/ as expected
• nftearth is good, same story as above
• quix has been moved to new directory as well, but the schema / source file remain in old directory models/quix/optimism/ rather than new directory models/_sector/nft/ -- or maybe just dupes?
  • @0xRobin can you double check these schema / source files for quix and clean up in follow-up PR as needed?

[0xRobin]

good catch, I'll move the schema/sources over. 👍

[jeff-dude]

interesting that we had to override these for spark/databricks, but not trino, for s3 location stuff mostly it seems. these macro removals will be good first candidates if anything breaks