Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: "Find in page" incorrectly starts from a higher activeMAtchIndex instead of 1 #5668

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Bug fix: "Find in page" incorrectly starts from a higher activeMAtchIndex instead of 1 #5668

wants to merge 1 commit into from

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Feb 19, 2025 •
edited by joshliebe
Loading

Task/Issue URL: https://app.asana.com/0/1201807753394693/1209380103848620

Description

See #5636

Steps to test this PR

  • Open the page you want to search, e.g., www.wikipedia.org.
  • Tap the 'three-dot' menu button.
  • Tap 'Find in page' button.
  • Enter your search term or phrase in the search bar, e.g., 'h'.
  • The search results should display '1/16' as the initial match, especially since the page is at the top without any scrolling.

No UI changes

@nalcalag
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag marked this pull request as ready for review February 20, 2025 11:29
@joshliebe joshliebe self-assigned this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshliebe joshliebe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalcalag @joshliebe