Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the build command for tagging immediately. #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use the build command for tagging immediately. #230

wants to merge 1 commit into from

Conversation

Beanow
Copy link

@Beanow Beanow commented Apr 17, 2019

Fixes #229

Copy link
Member

@bradrydzewski bradrydzewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this plugin is largely stable and frozen, therefore I prefer we avoid any major changes to how this works. Instead we should fix this at the Drone level and capture the sha for Gogs tags.

@tboerger
Copy link

I'm fine with directly tagging all versions, but even if we focus it on that it's a duplicate of #174

@Beanow
Copy link
Author

Beanow commented Apr 23, 2019

I'm fine with directly tagging all versions, but even if we focus it on that it's a duplicate of #174

I'd be as happy with #174 being merged, since it no longer requires build.Name (i.e. the git sha) as input for building the docker commands and resolves #229.

@bradrydzewski
Copy link
Member

+1 for #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto tag build fails when tag event has no commit sha (Gogs)
3 participants