Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create image tags at build time #174

Closed
wants to merge 1 commit into from

Conversation

tuxity
Copy link

@tuxity tuxity commented Mar 7, 2018

Instead of doing a docker tag at the end of the build, we can do it directly in the docker build command (since version 1.10)

@tboerger
Copy link

Since 1.10 you can append multiple -t flags?

@tuxity
Copy link
Author

tuxity commented Mar 12, 2018

Yes, directly into docker build command.

https://docs.docker.com/engine/reference/commandline/build/#tag-an-image--t

@Beanow
Copy link

Beanow commented Apr 23, 2019

Note, there's still a docker rmi {build.Name} command being executed at https://github.com/drone-plugins/drone-docker/pull/174/files#diff-d3a679229fa5a654b0e1d154531ac1e1R127

This change no longer builds an image with this reference name anymore though so it may not have the intended effect.

@bradrydzewski
Copy link
Member

before merging this, we should tag a new release so that we have something to rollback to if we encounter any unforseen issues.

@tuxity tuxity force-pushed the build_tags branch 2 times, most recently from a7fd761 to 6168e07 Compare April 24, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants