Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set canonical_version in mike configuration #398

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Feb 3, 2024

Currently, any particular version of the docs has header metadata like

<link rel="canonical" href="https://cloudpathlib.drivendata.org/v0.16/authentication/">

that references itself.

This configuration change will cause it to instead set it to

<link rel="canonical" href="https://cloudpathlib.drivendata.org/stable/authentication/">

This will only change for future deploys going forward. I've tested this by manually doing a staged deploy for latest, and it seems to work, and I will manually edit existing deploys on the gh-pages branch. (See #399)

Closes #397

Copy link
Contributor

github-actions bot commented Feb 3, 2024

@github-actions github-actions bot temporarily deployed to pull request February 3, 2024 00:30 Inactive
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (991704a) 94.1% compared to head (498a952) 94.4%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #398     +/-   ##
========================================
+ Coverage    94.1%   94.4%   +0.3%     
========================================
  Files          22      22             
  Lines        1560    1560             
========================================
+ Hits         1468    1474      +6     
+ Misses         92      86      -6     

see 3 files with indirect coverage changes

@jayqi jayqi requested a review from pjbull February 3, 2024 01:02
@pjbull pjbull merged commit 96884d9 into master Feb 4, 2024
28 checks passed
@pjbull pjbull deleted the 397-mike-canonical_version branch February 4, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google search results turn up old versions of docs
2 participants